Page MenuHomePhabricator
Files F14777658

D8628.diff
No OneTemporary
Actions

D8628.diff
View Options

diff --git a/src/applications/releeph/controller/project/ReleephProjectEditController.php b/src/applications/releeph/controller/project/ReleephProjectEditController.php
--- a/src/applications/releeph/controller/project/ReleephProjectEditController.php
+++ b/src/applications/releeph/controller/project/ReleephProjectEditController.php
@@ -31,10 +31,6 @@
$test_paths = $this->getReleephProject()->getDetail('testPaths', array());
}
- $release_counter = $request->getInt(
- 'releaseCounter',
- $this->getReleephProject()->getCurrentReleaseNumber());
-
$arc_project_id = $this->getReleephProject()->getArcanistProjectID();
if ($request->isFormPost()) {
@@ -52,10 +48,6 @@
pht('You must specify which branch you will be picking from.');
}
- if ($release_counter && !is_int($release_counter)) {
- $errors[] = pht("Release counter must be a positive integer!");
- }
-
$other_releeph_projects = id(new ReleephProject())
->loadAllWhere('id <> %d', $this->getReleephProject()->getID());
$other_releeph_project_names = mpull($other_releeph_projects,
@@ -83,10 +75,6 @@
->setDetail('commitWithAuthor', $commit_author)
->setDetail('testPaths', $test_paths);
- if ($release_counter) {
- $project->setDetail('releaseCounter', $release_counter);
- }
-
$fake_commit_handle =
ReleephBranchTemplate::getFakeCommitHandleFor($arc_project_id);
@@ -170,13 +158,6 @@
->setName('trunkBranch')
->setError($e_trunk_branch))
->appendChild(
- id(new AphrontFormTextControl())
- ->setLabel(pht('Release counter'))
- ->setValue($release_counter)
- ->setName('releaseCounter')
- ->setCaption(
- pht("Used by the command line branch cutter's %%N field")))
- ->appendChild(
id(new AphrontFormTextAreaControl())
->setLabel(pht('Pick Instructions'))
->setValue($pick_failure_instructions)
diff --git a/src/applications/releeph/storage/ReleephProject.php b/src/applications/releeph/storage/ReleephProject.php
--- a/src/applications/releeph/storage/ReleephProject.php
+++ b/src/applications/releeph/storage/ReleephProject.php
@@ -68,10 +68,6 @@
$this->name,
implode(', ', $banned_names)));
}
-
- if (!$this->getDetail('releaseCounter')) {
- $this->setDetail('releaseCounter', 0);
- }
}
public function loadArcanistProject() {
@@ -120,25 +116,6 @@
'getRepositoryPHID');
}
- public function getCurrentReleaseNumber() {
- $current_release_numbers = array();
-
- // From the project...
- $current_release_numbers[] = $this->getDetail('releaseCounter', 0);
-
- // From any branches...
- $branches = id(new ReleephBranch())->loadAllWhere(
- 'releephProjectID = %d', $this->getID());
- if ($branches) {
- $release_numbers = array();
- foreach ($branches as $branch) {
- $current_release_numbers[] = $branch->getDetail('releaseNumber', 0);
- }
- }
-
- return max($current_release_numbers);
- }
-
public function getReleephFieldSelector() {
return new ReleephDefaultFieldSelector();
}

File Metadata

Mime Type
text/plain
Expires
Sat, Jan 25, 5:12 AM (20 h, 29 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7047104
Default Alt Text
D8628.diff (3 KB)

Event Timeline

Phabricator · Built by Phacility