Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14766788
D14646.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D14646.diff
View Options
diff --git a/src/applications/phame/storage/PhamePostTransaction.php b/src/applications/phame/storage/PhamePostTransaction.php
--- a/src/applications/phame/storage/PhamePostTransaction.php
+++ b/src/applications/phame/storage/PhamePostTransaction.php
@@ -185,7 +185,7 @@
return parent::getTitleForFeed();
}
- public function getBodyForFeed(PhabricatorFeedStory $story) {
+ public function getRemarkupBodyForFeed(PhabricatorFeedStory $story) {
$text = null;
switch ($this->getTransactionType()) {
case self::TYPE_TITLE:
@@ -205,11 +205,7 @@
break;
}
- if (strlen($text)) {
- return PhabricatorMarkupEngine::summarize($text);
- }
-
- return parent::getBodyForFeed($story);
+ return $text;
}
public function getColor() {
diff --git a/src/applications/transactions/storage/PhabricatorApplicationTransaction.php b/src/applications/transactions/storage/PhabricatorApplicationTransaction.php
--- a/src/applications/transactions/storage/PhabricatorApplicationTransaction.php
+++ b/src/applications/transactions/storage/PhabricatorApplicationTransaction.php
@@ -964,6 +964,12 @@
}
public function getBodyForFeed(PhabricatorFeedStory $story) {
+ $remarkup = $this->getRemarkupBodyForFeed($story);
+ if ($remarkup !== null) {
+ $remarkup = PhabricatorMarkupEngine::summarize($remarkup);
+ return new PHUIRemarkupView($this->viewer, $remarkup);
+ }
+
$old = $this->getOldValue();
$new = $this->getNewValue();
@@ -981,6 +987,10 @@
return $body;
}
+ public function getRemarkupBodyForFeed(PhabricatorFeedStory $story) {
+ return null;
+ }
+
public function getActionStrength() {
if ($this->isInlineCommentTransaction()) {
return 0.25;
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Fri, Jan 24, 4:59 PM (19 h, 55 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7041955
Default Alt Text
D14646.diff (1 KB)
Attached To
Mode
D14646: Render Remarkup poorly in Phame Feed stories
Attached
Detach File
Event Timeline
Log In to Comment