Page MenuHomePhabricator
Files F14760115

D13423.id.diff
No OneTemporary
Actions

D13423.id.diff
View Options

diff --git a/src/configuration/ArcanistConfigurationManager.php b/src/configuration/ArcanistConfigurationManager.php
--- a/src/configuration/ArcanistConfigurationManager.php
+++ b/src/configuration/ArcanistConfigurationManager.php
@@ -13,6 +13,7 @@
public function setWorkingCopyIdentity(
ArcanistWorkingCopyIdentity $working_copy) {
$this->workingCopy = $working_copy;
+ return $this;
}
/* -( Get config )--------------------------------------------------------- */
@@ -243,6 +244,7 @@
$this->customArcrcFilename = $custom_arcrc;
$this->userConfigCache = null;
+ return $this;
}
public function getUserConfigurationFileLocation() {
diff --git a/src/lint/linter/xhpast/ArcanistXHPASTLinterRule.php b/src/lint/linter/xhpast/ArcanistXHPASTLinterRule.php
--- a/src/lint/linter/xhpast/ArcanistXHPASTLinterRule.php
+++ b/src/lint/linter/xhpast/ArcanistXHPASTLinterRule.php
@@ -69,6 +69,7 @@
final public function setLinter(ArcanistXHPASTLinter $linter) {
$this->linter = $linter;
+ return $this;
}
/**
diff --git a/src/unit/engine/NoseTestEngine.php b/src/unit/engine/NoseTestEngine.php
--- a/src/unit/engine/NoseTestEngine.php
+++ b/src/unit/engine/NoseTestEngine.php
@@ -64,7 +64,7 @@
foreach ($futures as $test_path => $future) {
try {
list($stdout, $stderr) = $future->resolvex();
- } catch(CommandException $exc) {
+ } catch (CommandException $exc) {
if ($exc->getError() > 1) {
// 'nose' returns 1 when tests are failing/broken.
throw $exc;
diff --git a/src/unit/engine/XUnitTestEngine.php b/src/unit/engine/XUnitTestEngine.php
--- a/src/unit/engine/XUnitTestEngine.php
+++ b/src/unit/engine/XUnitTestEngine.php
@@ -250,7 +250,7 @@
try {
$regenerate_future->resolvex();
$result->setResult(ArcanistUnitTestResult::RESULT_PASS);
- } catch(CommandException $exc) {
+ } catch (CommandException $exc) {
if ($exc->getError() > 1) {
throw $exc;
}
@@ -296,7 +296,7 @@
try {
$future->resolvex();
$result->setResult(ArcanistUnitTestResult::RESULT_PASS);
- } catch(CommandException $exc) {
+ } catch (CommandException $exc) {
if ($exc->getError() > 1) {
throw $exc;
}

File Metadata

Mime Type
text/plain
Expires
Thu, Jan 23, 4:11 PM (13 h, 29 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7037413
Default Alt Text
D13423.id.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility