Page MenuHomePhabricator
Files F14738130

D15617.diff
No OneTemporary
Actions

D15617.diff
View Options

diff --git a/src/applications/help/controller/PhabricatorHelpDocumentationController.php b/src/applications/help/controller/PhabricatorHelpDocumentationController.php
--- a/src/applications/help/controller/PhabricatorHelpDocumentationController.php
+++ b/src/applications/help/controller/PhabricatorHelpDocumentationController.php
@@ -38,14 +38,10 @@
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addTextCrumb($title);
- return $this->buildApplicationPage(
- array(
- $crumbs,
- $list,
- ),
- array(
- 'title' => $title,
- ));
+ return $this->newPage()
+ ->setTitle($title)
+ ->setCrumbs($crumbs)
+ ->appendChild($list);
}
diff --git a/src/applications/help/controller/PhabricatorHelpEditorProtocolController.php b/src/applications/help/controller/PhabricatorHelpEditorProtocolController.php
--- a/src/applications/help/controller/PhabricatorHelpEditorProtocolController.php
+++ b/src/applications/help/controller/PhabricatorHelpEditorProtocolController.php
@@ -10,8 +10,7 @@
public function handleRequest(AphrontRequest $request) {
$viewer = $request->getViewer();
- $dialog = id(new AphrontDialogView())
- ->setUser($viewer)
+ return $this->newDialog()
->setMethod('GET')
->setSubmitURI('/settings/panel/display/')
->setTitle(pht('Unsupported Editor Protocol'))
@@ -24,9 +23,6 @@
phutil_tag('tt', array(), 'uri.allowed-editor-protocols')))
->addSubmitButton(pht('Change Settings'))
->addCancelButton('/');
-
- return id(new AphrontDialogResponse())
- ->setDialog($dialog);
}
public static function hasAllowedProtocol($uri) {
diff --git a/src/applications/help/controller/PhabricatorHelpKeyboardShortcutController.php b/src/applications/help/controller/PhabricatorHelpKeyboardShortcutController.php
--- a/src/applications/help/controller/PhabricatorHelpKeyboardShortcutController.php
+++ b/src/applications/help/controller/PhabricatorHelpKeyboardShortcutController.php
@@ -57,14 +57,11 @@
array('class' => 'keyboard-shortcut-help'),
$rows);
- $dialog = id(new AphrontDialogView())
- ->setUser($viewer)
+ return $this->newDialog()
->setTitle(pht('Keyboard Shortcuts'))
->appendChild($table)
->addCancelButton('#', pht('Close'));
- return id(new AphrontDialogResponse())
- ->setDialog($dialog);
}
}

File Metadata

Mime Type
text/plain
Expires
Mon, Jan 20, 11:38 AM (21 h, 23 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7022815
Default Alt Text
D15617.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility