Page MenuHomePhabricator
Files F14725280

D8693.diff
No OneTemporary
Actions

D8693.diff
View Options

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -7,7 +7,7 @@
return array(
'names' =>
array(
- 'core.pkg.css' => 'fb144113',
+ 'core.pkg.css' => '1f7a202d',
'core.pkg.js' => '57d0e1c4',
'darkconsole.pkg.js' => 'ca8671ce',
'differential.pkg.css' => '331c38d9',
@@ -22,7 +22,7 @@
'rsrc/css/aphront/context-bar.css' => '1c3b0529',
'rsrc/css/aphront/dark-console.css' => '6378ef3d',
'rsrc/css/aphront/dialog-view.css' => 'c01d24b4',
- 'rsrc/css/aphront/error-view.css' => '16cd9949',
+ 'rsrc/css/aphront/error-view.css' => '9f1d5518',
'rsrc/css/aphront/lightbox-attachment.css' => '7acac05d',
'rsrc/css/aphront/list-filter-view.css' => 'ef989c67',
'rsrc/css/aphront/multi-column.css' => '12f65921',
@@ -486,7 +486,7 @@
'aphront-contextbar-view-css' => '1c3b0529',
'aphront-dark-console-css' => '6378ef3d',
'aphront-dialog-view-css' => 'c01d24b4',
- 'aphront-error-view-css' => '16cd9949',
+ 'aphront-error-view-css' => '9f1d5518',
'aphront-list-filter-view-css' => 'ef989c67',
'aphront-multi-column-view-css' => '12f65921',
'aphront-notes' => '6acadd3f',
diff --git a/src/applications/differential/render/DifferentialChangesetHTMLRenderer.php b/src/applications/differential/render/DifferentialChangesetHTMLRenderer.php
--- a/src/applications/differential/render/DifferentialChangesetHTMLRenderer.php
+++ b/src/applications/differential/render/DifferentialChangesetHTMLRenderer.php
@@ -358,6 +358,17 @@
$content)));
}
+ private function renderColgroup() {
+ return phutil_tag('colgroup', array(), array(
+ phutil_tag('col', array('class' => 'num')),
+ phutil_tag('col', array('class' => 'left')),
+ phutil_tag('col', array('class' => 'num')),
+ phutil_tag('col', array('class' => 'copy')),
+ phutil_tag('col', array('class' => 'right')),
+ phutil_tag('col', array('class' => 'cov')),
+ ));
+ }
+
protected function wrapChangeInTable($content) {
if (!$content) {
return null;
@@ -369,7 +380,10 @@
'class' => 'differential-diff remarkup-code PhabricatorMonospaced',
'sigil' => 'differential-diff',
),
- $content);
+ array(
+ $this->renderColgroup(),
+ $content,
+ ));
}
protected function renderInlineComment(
diff --git a/src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php b/src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php
--- a/src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php
+++ b/src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php
@@ -7,17 +7,6 @@
return false;
}
- private function renderColgroup() {
- return phutil_tag('colgroup', array(), array(
- phutil_tag('col', array('class' => 'num')),
- phutil_tag('col', array('class' => 'left')),
- phutil_tag('col', array('class' => 'num')),
- phutil_tag('col', array('class' => 'copy')),
- phutil_tag('col', array('class' => 'right')),
- phutil_tag('col', array('class' => 'cov')),
- ));
- }
-
public function renderTextChange(
$range_start,
$range_len,
@@ -42,7 +31,6 @@
}
$html = array();
- $html[] = $this->renderColgroup();
$old_lines = $this->getOldLines();
$new_lines = $this->getNewLines();
@@ -438,10 +426,7 @@
$th_new = phutil_tag('th', array('id' => "C{$id}OL1"), 1);
}
- $output = array();
- $output[] = $this->renderColgroup();
-
- $output[] = hsprintf(
+ $output = hsprintf(
'<tr class="differential-image-diff">'.
'%s'.
'<td class="differential-old-image">%s</td>'.

File Metadata

Mime Type
text/plain
Expires
Sun, Jan 19, 2:11 AM (17 h, 8 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7015331
Default Alt Text
D8693.diff (3 KB)

Event Timeline

Phabricator · Built by Phacility