Page MenuHomePhabricator
Files F14717231

D11347.diff
No OneTemporary
Actions

D11347.diff
View Options

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -7,7 +7,7 @@
*/
return array(
'names' => array(
- 'core.pkg.css' => '2b129813',
+ 'core.pkg.css' => 'b99369cc',
'core.pkg.js' => '61af8961',
'darkconsole.pkg.js' => '8ab24e01',
'differential.pkg.css' => '8af45893',
@@ -130,7 +130,7 @@
'rsrc/css/phui/phui-fontkit.css' => '9c3d2dce',
'rsrc/css/phui/phui-form-view.css' => 'aad06f2a',
'rsrc/css/phui/phui-form.css' => '9aecbda1',
- 'rsrc/css/phui/phui-header-view.css' => '0873d56f',
+ 'rsrc/css/phui/phui-header-view.css' => 'c936b5b9',
'rsrc/css/phui/phui-icon.css' => 'a013a63d',
'rsrc/css/phui/phui-image-mask.css' => '5a8b09c8',
'rsrc/css/phui/phui-info-panel.css' => '27ea50a1',
@@ -774,7 +774,7 @@
'phui-fontkit-css' => '9c3d2dce',
'phui-form-css' => '9aecbda1',
'phui-form-view-css' => 'aad06f2a',
- 'phui-header-view-css' => '0873d56f',
+ 'phui-header-view-css' => 'c936b5b9',
'phui-icon-view-css' => 'a013a63d',
'phui-image-mask-css' => '5a8b09c8',
'phui-info-panel-css' => '27ea50a1',
diff --git a/src/view/phui/PHUIButtonView.php b/src/view/phui/PHUIButtonView.php
--- a/src/view/phui/PHUIButtonView.php
+++ b/src/view/phui/PHUIButtonView.php
@@ -22,9 +22,6 @@
private $title = null;
private $disabled;
private $name;
- private $id;
- private $sigil;
- private $meta;
public function setName($name) {
$this->name = $name;
@@ -85,21 +82,6 @@
return $this;
}
- public function setID($id) {
- $this->id = $id;
- return $this;
- }
-
- public function setSigil($sigil) {
- $this->sigil = $sigil;
- return $this;
- }
-
- public function setMeta($meta) {
- $this->meta = $meta;
- return $this;
- }
-
public function getTagName() {
return $this->tag;
}
@@ -136,9 +118,6 @@
'href' => $this->href,
'name' => $this->name,
'title' => $this->title,
- 'id' => $this->id,
- 'sigil' => $this->sigil,
- 'meta' => $this->meta,
);
}
diff --git a/src/view/phui/PHUIObjectBoxView.php b/src/view/phui/PHUIObjectBoxView.php
--- a/src/view/phui/PHUIObjectBoxView.php
+++ b/src/view/phui/PHUIObjectBoxView.php
@@ -170,7 +170,7 @@
$meta = array(
'map' => array(
$this->actionListID => 'phabricator-action-list-toggle',
- $icon_id => 'phui-mobile-action-menu-open',
+ $icon_id => 'phuix-dropdown-open',
),);
$mobile_menu = id(new PHUIButtonView())
->setTag('a')
@@ -179,8 +179,8 @@
->setIcon($icon)
->addClass('phui-mobile-menu')
->setID($icon_id)
- ->setSigil('jx-toggle-class')
- ->setMeta($meta);
+ ->addSigil('jx-toggle-class')
+ ->setMetadata($meta);
$header->addActionLink($mobile_menu);
}
diff --git a/webroot/rsrc/css/phui/phui-header-view.css b/webroot/rsrc/css/phui/phui-header-view.css
--- a/webroot/rsrc/css/phui/phui-header-view.css
+++ b/webroot/rsrc/css/phui/phui-header-view.css
@@ -146,7 +146,3 @@
.device .phui-header-action-links .phui-mobile-menu {
display: inline-block;
}
-
-.phui-mobile-action-menu-open {
- background: white !important;
-}

File Metadata

Mime Type
text/plain
Expires
Sat, Jan 18, 7:27 PM (20 h, 33 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7004661
Default Alt Text
D11347.diff (3 KB)

Event Timeline

Phabricator · Built by Phacility