Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14690986
D14486.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D14486.diff
View Options
diff --git a/src/unit/engine/ArcanistUnitTestEngine.php b/src/unit/engine/ArcanistUnitTestEngine.php
--- a/src/unit/engine/ArcanistUnitTestEngine.php
+++ b/src/unit/engine/ArcanistUnitTestEngine.php
@@ -8,7 +8,6 @@
private $workingCopy;
private $paths = array();
private $arguments = array();
- private $enableAsyncTests;
private $enableCoverage;
private $runAllTests;
private $configurationManager;
@@ -80,15 +79,6 @@
return idx($this->arguments, $key, $default);
}
- final public function setEnableAsyncTests($enable_async_tests) {
- $this->enableAsyncTests = $enable_async_tests;
- return $this;
- }
-
- final public function getEnableAsyncTests() {
- return $this->enableAsyncTests;
- }
-
final public function setEnableCoverage($enable_coverage) {
$this->enableCoverage = $enable_coverage;
return $this;
diff --git a/src/workflow/ArcanistUnitWorkflow.php b/src/workflow/ArcanistUnitWorkflow.php
--- a/src/workflow/ArcanistUnitWorkflow.php
+++ b/src/workflow/ArcanistUnitWorkflow.php
@@ -165,13 +165,6 @@
}
$this->engine->setEnableCoverage($enable_coverage);
- // Enable possible async tests only for 'arc diff' not 'arc unit'
- if ($this->getParentWorkflow()) {
- $this->engine->setEnableAsyncTests(true);
- } else {
- $this->engine->setEnableAsyncTests(false);
- }
-
$results = $this->engine->run();
$this->validateUnitEngineResults($this->engine, $results);
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Wed, Jan 15, 2:39 AM (10 h, 13 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6993458
Default Alt Text
D14486.diff (1 KB)
Attached To
Mode
D14486: Remove "async" mode from test engines
Attached
Detach File
Event Timeline
Log In to Comment