Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14670404
D8319.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
896 B
Referenced Files
None
Subscribers
None
D8319.diff
View Options
Index: src/auth/PhutilAuthAdapterOAuth.php
===================================================================
--- src/auth/PhutilAuthAdapterOAuth.php
+++ src/auth/PhutilAuthAdapterOAuth.php
@@ -21,9 +21,8 @@
$uri->setQueryParam('client_id', $this->getClientID());
$uri->setQueryParam('scope', $this->getScope());
$uri->setQueryParam('redirect_uri', $this->getRedirectURI());
- if ($this->supportsStateParameter()) {
- $uri->setQueryParam('state', $this->getState());
- }
+ $uri->setQueryParam('state', $this->getState());
+
foreach ($this->getExtraAuthenticateParameters() as $key => $value) {
$uri->setQueryParam($key, $value);
}
@@ -37,10 +36,6 @@
return strtolower($type_name);
}
- public function supportsStateParameter() {
- return true;
- }
-
public function setState($state) {
$this->state = $state;
return $this;
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Mon, Jan 13, 4:20 PM (14 h, 45 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6989823
Default Alt Text
D8319.diff (896 B)
Attached To
Mode
D8319: Remove "supportsStateParameter()" from generic OAuth2 code
Attached
Detach File
Event Timeline
Log In to Comment