Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14648553
D21464.id51091.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
877 B
Referenced Files
None
Subscribers
None
D21464.id51091.diff
View Options
diff --git a/src/applications/conduit/controller/PhabricatorConduitAPIController.php b/src/applications/conduit/controller/PhabricatorConduitAPIController.php
--- a/src/applications/conduit/controller/PhabricatorConduitAPIController.php
+++ b/src/applications/conduit/controller/PhabricatorConduitAPIController.php
@@ -100,9 +100,17 @@
}
} catch (Exception $ex) {
$result = null;
- $error_code = ($ex instanceof ConduitException
- ? 'ERR-CONDUIT-CALL'
- : 'ERR-CONDUIT-CORE');
+
+ if ($ex instanceof ConduitException) {
+ $error_code = 'ERR-CONDUIT-CALL';
+ } else {
+ $error_code = 'ERR-CONDUIT-CORE';
+
+ // See T13581. When a Conduit method raises an uncaught exception
+ // other than a "ConduitException", log it.
+ phlog($ex);
+ }
+
$error_info = $ex->getMessage();
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Jan 12, 2:23 PM (20 h, 39 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6986405
Default Alt Text
D21464.id51091.diff (877 B)
Attached To
Mode
D21464: Log unexpected exceptions raised by Conduit calls
Attached
Detach File
Event Timeline
Log In to Comment