Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14631103
D21263.id50632.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
3 KB
Referenced Files
None
Subscribers
None
D21263.id50632.diff
View Options
diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -13,7 +13,7 @@
'core.pkg.js' => '845355f4',
'dark-console.pkg.js' => '187792c2',
'differential.pkg.css' => '42a2334f',
- 'differential.pkg.js' => '623b4801',
+ 'differential.pkg.js' => 'b57da3e7',
'diffusion.pkg.css' => '42c75c37',
'diffusion.pkg.js' => 'a98c0bf7',
'maniphest.pkg.css' => '35995d6d',
@@ -379,7 +379,7 @@
'rsrc/js/application/dashboard/behavior-dashboard-move-panels.js' => 'a2ab19be',
'rsrc/js/application/dashboard/behavior-dashboard-query-panel-select.js' => '1e413dc9',
'rsrc/js/application/dashboard/behavior-dashboard-tab-panel.js' => '0116d3e8',
- 'rsrc/js/application/diff/DiffChangeset.js' => '68d963eb',
+ 'rsrc/js/application/diff/DiffChangeset.js' => '0c083409',
'rsrc/js/application/diff/DiffChangesetList.js' => 'ac403c32',
'rsrc/js/application/diff/DiffInline.js' => 'b00168c1',
'rsrc/js/application/diff/DiffPathView.js' => '8207abf9',
@@ -774,7 +774,7 @@
'phabricator-darklog' => '3b869402',
'phabricator-darkmessage' => '26cd4b73',
'phabricator-dashboard-css' => '5a205b9d',
- 'phabricator-diff-changeset' => '68d963eb',
+ 'phabricator-diff-changeset' => '0c083409',
'phabricator-diff-changeset-list' => 'ac403c32',
'phabricator-diff-inline' => 'b00168c1',
'phabricator-diff-path-view' => '8207abf9',
@@ -1000,6 +1000,19 @@
'javelin-dom',
'phabricator-draggable-list',
),
+ '0c083409' => array(
+ 'javelin-dom',
+ 'javelin-util',
+ 'javelin-stratcom',
+ 'javelin-install',
+ 'javelin-workflow',
+ 'javelin-router',
+ 'javelin-behavior-device',
+ 'javelin-vector',
+ 'phabricator-diff-inline',
+ 'phabricator-diff-path-view',
+ 'phuix-button-view',
+ ),
'0cf79f45' => array(
'javelin-behavior',
'javelin-stratcom',
@@ -1512,19 +1525,6 @@
'javelin-install',
'javelin-dom',
),
- '68d963eb' => array(
- 'javelin-dom',
- 'javelin-util',
- 'javelin-stratcom',
- 'javelin-install',
- 'javelin-workflow',
- 'javelin-router',
- 'javelin-behavior-device',
- 'javelin-vector',
- 'phabricator-diff-inline',
- 'phabricator-diff-path-view',
- 'phuix-button-view',
- ),
'6a1583a8' => array(
'javelin-behavior',
'javelin-history',
diff --git a/webroot/rsrc/js/application/diff/DiffChangeset.js b/webroot/rsrc/js/application/diff/DiffChangeset.js
--- a/webroot/rsrc/js/application/diff/DiffChangeset.js
+++ b/webroot/rsrc/js/application/diff/DiffChangeset.js
@@ -795,8 +795,10 @@
},
_findInline: function(field, value) {
- for (var ii = 0; ii < this._inlines.length; ii++) {
- var inline = this._inlines[ii];
+ var inlines = this.getInlines();
+
+ for (var ii = 0; ii < inlines.length; ii++) {
+ var inline = inlines[ii];
var target;
switch (field) {
@@ -844,7 +846,7 @@
},
redrawFileTree: function() {
- var inlines = this._inlines;
+ var inlines = this.getInlines();
var done = [];
var undone = [];
var inline;
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Jan 11, 6:10 PM (17 h, 12 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6985443
Default Alt Text
D21263.id50632.diff (3 KB)
Attached To
Mode
D21263: Fix an out-of-order access issue with inlines
Attached
Detach File
Event Timeline
Log In to Comment