Page MenuHomePhabricator
Files F14608085

D11322.id27225.diff
No OneTemporary
Actions

D11322.id27225.diff
View Options

diff --git a/src/lint/linter/ArcanistCSSLintLinter.php b/src/lint/linter/ArcanistCSSLintLinter.php
--- a/src/lint/linter/ArcanistCSSLintLinter.php
+++ b/src/lint/linter/ArcanistCSSLintLinter.php
@@ -58,10 +58,6 @@
'npm install -g csslint');
}
- public function shouldExpectCommandErrors() {
- return true;
- }
-
protected function parseLinterOutput($path, $err, $stdout, $stderr) {
$report_dom = new DOMDocument();
$ok = @$report_dom->loadXML($stdout);
diff --git a/src/lint/linter/ArcanistClosureLinter.php b/src/lint/linter/ArcanistClosureLinter.php
--- a/src/lint/linter/ArcanistClosureLinter.php
+++ b/src/lint/linter/ArcanistClosureLinter.php
@@ -37,10 +37,6 @@
'files/closure_linter-latest.tar.gz');
}
- public function shouldExpectCommandErrors() {
- return true;
- }
-
public function supportsReadDataFromStdin() {
return false;
}
diff --git a/src/lint/linter/ArcanistCoffeeLintLinter.php b/src/lint/linter/ArcanistCoffeeLintLinter.php
--- a/src/lint/linter/ArcanistCoffeeLintLinter.php
+++ b/src/lint/linter/ArcanistCoffeeLintLinter.php
@@ -47,10 +47,6 @@
'npm install -g coffeelint');
}
- public function shouldExpectCommandErrors() {
- return true;
- }
-
public function supportsReadDataFromStdin() {
return true;
}
diff --git a/src/lint/linter/ArcanistCppcheckLinter.php b/src/lint/linter/ArcanistCppcheckLinter.php
--- a/src/lint/linter/ArcanistCppcheckLinter.php
+++ b/src/lint/linter/ArcanistCppcheckLinter.php
@@ -67,6 +67,10 @@
array('-j2', '--enable=performance,style,portability,information'));
}
+ public function shouldExpectCommandErrors() {
+ return false;
+ }
+
protected function parseLinterOutput($path, $err, $stdout, $stderr) {
$dom = new DOMDocument();
$ok = @$dom->loadXML($stderr);
diff --git a/src/lint/linter/ArcanistCpplintLinter.php b/src/lint/linter/ArcanistCpplintLinter.php
--- a/src/lint/linter/ArcanistCpplintLinter.php
+++ b/src/lint/linter/ArcanistCpplintLinter.php
@@ -29,10 +29,6 @@
'googlecode.com/svn/trunk/cpplint/cpplint.py`.');
}
- public function shouldExpectCommandErrors() {
- return true;
- }
-
public function supportsReadDataFromStdin() {
return true;
}
diff --git a/src/lint/linter/ArcanistExternalLinter.php b/src/lint/linter/ArcanistExternalLinter.php
--- a/src/lint/linter/ArcanistExternalLinter.php
+++ b/src/lint/linter/ArcanistExternalLinter.php
@@ -56,7 +56,7 @@
* @task bin
*/
public function shouldExpectCommandErrors() {
- return false;
+ return true;
}
/**
diff --git a/src/lint/linter/ArcanistFlake8Linter.php b/src/lint/linter/ArcanistFlake8Linter.php
--- a/src/lint/linter/ArcanistFlake8Linter.php
+++ b/src/lint/linter/ArcanistFlake8Linter.php
@@ -58,10 +58,6 @@
return pht('Install flake8 using `easy_install flake8`.');
}
- public function shouldExpectCommandErrors() {
- return true;
- }
-
protected function parseLinterOutput($path, $err, $stdout, $stderr) {
$lines = phutil_split_lines($stdout, false);
diff --git a/src/lint/linter/ArcanistGoLintLinter.php b/src/lint/linter/ArcanistGoLintLinter.php
--- a/src/lint/linter/ArcanistGoLintLinter.php
+++ b/src/lint/linter/ArcanistGoLintLinter.php
@@ -30,6 +30,10 @@
return pht('Install Golint using `go get github.com/golang/lint/golint`.');
}
+ public function shouldExpectCommandErrors() {
+ return false;
+ }
+
protected function canCustomizeLintSeverities() {
return true;
}
diff --git a/src/lint/linter/ArcanistHLintLinter.php b/src/lint/linter/ArcanistHLintLinter.php
--- a/src/lint/linter/ArcanistHLintLinter.php
+++ b/src/lint/linter/ArcanistHLintLinter.php
@@ -41,10 +41,6 @@
return '-';
}
- public function shouldExpectCommandErrors() {
- return true;
- }
-
protected function getMandatoryFlags() {
return array('--json');
}
diff --git a/src/lint/linter/ArcanistJSHintLinter.php b/src/lint/linter/ArcanistJSHintLinter.php
--- a/src/lint/linter/ArcanistJSHintLinter.php
+++ b/src/lint/linter/ArcanistJSHintLinter.php
@@ -73,10 +73,6 @@
return pht('Install JSHint using `npm install -g jshint`.');
}
- public function shouldExpectCommandErrors() {
- return true;
- }
-
public function supportsReadDataFromStdin() {
return true;
}
diff --git a/src/lint/linter/ArcanistJSONLintLinter.php b/src/lint/linter/ArcanistJSONLintLinter.php
--- a/src/lint/linter/ArcanistJSONLintLinter.php
+++ b/src/lint/linter/ArcanistJSONLintLinter.php
@@ -47,10 +47,6 @@
return pht('Install jsonlint using `npm install -g jsonlint`.');
}
- public function shouldExpectCommandErrors() {
- return true;
- }
-
public function supportsReadDataFromStdin() {
return true;
}
diff --git a/src/lint/linter/ArcanistJscsLinter.php b/src/lint/linter/ArcanistJscsLinter.php
--- a/src/lint/linter/ArcanistJscsLinter.php
+++ b/src/lint/linter/ArcanistJscsLinter.php
@@ -45,10 +45,6 @@
return pht('Install JSCS using `npm install -g jscs`.');
}
- public function shouldExpectCommandErrors() {
- return true;
- }
-
protected function getMandatoryFlags() {
$options = array();
diff --git a/src/lint/linter/ArcanistLesscLinter.php b/src/lint/linter/ArcanistLesscLinter.php
--- a/src/lint/linter/ArcanistLesscLinter.php
+++ b/src/lint/linter/ArcanistLesscLinter.php
@@ -101,10 +101,6 @@
return pht('Install lessc using `npm install -g less`.');
}
- public function shouldExpectCommandErrors() {
- return true;
- }
-
public function supportsReadDataFromStdin() {
// Technically `lessc` can read data from standard input however, when doing
// so, relative imports cannot be resolved. Therefore, this functionality is
diff --git a/src/lint/linter/ArcanistPEP8Linter.php b/src/lint/linter/ArcanistPEP8Linter.php
--- a/src/lint/linter/ArcanistPEP8Linter.php
+++ b/src/lint/linter/ArcanistPEP8Linter.php
@@ -70,10 +70,6 @@
return pht('Install PEP8 using `easy_install pep8`.');
}
- public function shouldExpectCommandErrors() {
- return true;
- }
-
protected function parseLinterOutput($path, $err, $stdout, $stderr) {
$lines = phutil_split_lines($stdout, false);
diff --git a/src/lint/linter/ArcanistPhpLinter.php b/src/lint/linter/ArcanistPhpLinter.php
--- a/src/lint/linter/ArcanistPhpLinter.php
+++ b/src/lint/linter/ArcanistPhpLinter.php
@@ -55,10 +55,6 @@
return $stdout;
}
- public function shouldExpectCommandErrors() {
- return true;
- }
-
public function supportsReadDataFromStdin() {
return false;
}
diff --git a/src/lint/linter/ArcanistPhpcsLinter.php b/src/lint/linter/ArcanistPhpcsLinter.php
--- a/src/lint/linter/ArcanistPhpcsLinter.php
+++ b/src/lint/linter/ArcanistPhpcsLinter.php
@@ -68,10 +68,6 @@
}
}
- public function shouldExpectCommandErrors() {
- return true;
- }
-
public function supportsReadDataFromStdin() {
return true;
}
diff --git a/src/lint/linter/ArcanistPuppetLintLinter.php b/src/lint/linter/ArcanistPuppetLintLinter.php
--- a/src/lint/linter/ArcanistPuppetLintLinter.php
+++ b/src/lint/linter/ArcanistPuppetLintLinter.php
@@ -52,10 +52,6 @@
'gem install puppet-lint');
}
- public function shouldExpectCommandErrors() {
- return true;
- }
-
protected function getMandatoryFlags() {
return array(
'--error-level=all',
diff --git a/src/lint/linter/ArcanistPyFlakesLinter.php b/src/lint/linter/ArcanistPyFlakesLinter.php
--- a/src/lint/linter/ArcanistPyFlakesLinter.php
+++ b/src/lint/linter/ArcanistPyFlakesLinter.php
@@ -53,10 +53,6 @@
return pht('Install pyflakes with `pip install pyflakes`.');
}
- public function shouldExpectCommandErrors() {
- return true;
- }
-
public function supportsReadDataFromStdin() {
return true;
}
diff --git a/src/lint/linter/ArcanistRubyLinter.php b/src/lint/linter/ArcanistRubyLinter.php
--- a/src/lint/linter/ArcanistRubyLinter.php
+++ b/src/lint/linter/ArcanistRubyLinter.php
@@ -54,10 +54,6 @@
return true;
}
- public function shouldExpectCommandErrors() {
- return true;
- }
-
protected function getMandatoryFlags() {
// -w: turn on warnings
// -c: check syntax

File Metadata

Mime Type
text/plain
Expires
Fri, Jan 10, 8:06 AM (10 h, 39 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6981461
Default Alt Text
D11322.id27225.diff (8 KB)

Event Timeline

Phabricator · Built by Phacility