D9040.id21465.diff
No OneTemporary
Actions

Size

1013 B

Referenced Files

None

Subscribers

None

D9040.id21465.diff
View Options

	diff --git a/src/lint/linter/ArcanistPhutilXHPASTLinter.php b/src/lint/linter/ArcanistPhutilXHPASTLinter.php
	--- a/src/lint/linter/ArcanistPhutilXHPASTLinter.php
	+++ b/src/lint/linter/ArcanistPhutilXHPASTLinter.php
	@@ -107,7 +107,7 @@
	}


	- private function lintUnsafeDynamicString($root) {
	+ private function lintUnsafeDynamicString(XHPASTNode $root) {
	$safe = $this->dynamicStringFunctions + array(
	'pht' => 0,

	@@ -175,7 +175,7 @@
	}


	- private function lintArrayCombine($root) {
	+ private function lintArrayCombine(XHPASTNode $root) {
	$function_calls = $root->selectDescendantsOfType('n_FUNCTION_CALL');
	foreach ($function_calls as $call) {
	$name = $call->getChildByIndex(0)->getConcreteString();
	@@ -200,7 +200,7 @@
	}
	}

	- private function lintDeprecatedFunctions($root) {
	+ private function lintDeprecatedFunctions(XHPASTNode $root) {
	$map = $this->deprecatedFunctions;

	$function_calls = $root->selectDescendantsOfType('n_FUNCTION_CALL');