Page MenuHomePhabricator
Files F14425011

D15527.id37431.diff
No OneTemporary
Actions

D15527.id37431.diff
View Options

diff --git a/src/applications/almanac/controller/AlmanacBindingEditController.php b/src/applications/almanac/controller/AlmanacBindingEditController.php
--- a/src/applications/almanac/controller/AlmanacBindingEditController.php
+++ b/src/applications/almanac/controller/AlmanacBindingEditController.php
@@ -99,25 +99,35 @@
$box = id(new PHUIObjectBoxView())
->setValidationException($validation_exception)
- ->setHeaderText($title)
+ ->setHeaderText(pht('Binding'))
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->appendChild($form);
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addTextCrumb($service->getName(), $service_uri);
if ($is_new) {
$crumbs->addTextCrumb(pht('Create Binding'));
+ $header = id(new PHUIHeaderView())
+ ->setHeader(pht('Create Binding'))
+ ->setHeaderIcon('fa-plus-square');
} else {
$crumbs->addTextCrumb(pht('Edit Binding'));
+ $header = id(new PHUIHeaderView())
+ ->setHeader(pht('Create Binding'))
+ ->setHeaderIcon('fa-pencil');
}
+ $crumbs->setBorder(true);
+
+ $view = id(new PHUITwoColumnView())
+ ->setHeader($header)
+ ->setFooter(array(
+ $box,
+ ));
return $this->newPage()
->setTitle($title)
->setCrumbs($crumbs)
- ->appendChild(
- array(
- $box,
- ));
-
+ ->appendChild($view);
}
}
diff --git a/src/applications/almanac/controller/AlmanacConsoleController.php b/src/applications/almanac/controller/AlmanacConsoleController.php
--- a/src/applications/almanac/controller/AlmanacConsoleController.php
+++ b/src/applications/almanac/controller/AlmanacConsoleController.php
@@ -61,18 +61,25 @@
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addTextCrumb(pht('Console'));
+ $crumbs->setBorder(true);
$box = id(new PHUIObjectBoxView())
- ->setHeaderText(pht('Console'))
->setObjectList($menu);
+ $header = id(new PHUIHeaderView())
+ ->setHeader(pht('Almanac Console'))
+ ->setHeaderIcon('fa-server');
+
+ $view = id(new PHUITwoColumnView())
+ ->setHeader($header)
+ ->setFooter(array(
+ $box,
+ ));
+
return $this->newPage()
->setTitle(pht('Almanac Console'))
->setCrumbs($crumbs)
- ->appendChild(
- array(
- $box,
- ));
+ ->appendChild($view);
}
diff --git a/src/applications/almanac/controller/AlmanacInterfaceEditController.php b/src/applications/almanac/controller/AlmanacInterfaceEditController.php
--- a/src/applications/almanac/controller/AlmanacInterfaceEditController.php
+++ b/src/applications/almanac/controller/AlmanacInterfaceEditController.php
@@ -131,24 +131,36 @@
$box = id(new PHUIObjectBoxView())
->setValidationException($validation_exception)
- ->setHeaderText($title)
+ ->setHeaderText(pht('Interface'))
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setForm($form);
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addTextCrumb($device->getName(), $device_uri);
if ($is_new) {
$crumbs->addTextCrumb(pht('Create Interface'));
+ $header = id(new PHUIHeaderView())
+ ->setHeader(pht('Create Interface'))
+ ->setHeaderIcon('fa-plus-square');
} else {
$crumbs->addTextCrumb(pht('Edit Interface'));
+ $header = id(new PHUIHeaderView())
+ ->setHeader(pht('Edit Interface'))
+ ->setHeaderIcon('fa-pencil');
}
+ $crumbs->setBorder(true);
+
+ $view = id(new PHUITwoColumnView())
+ ->setHeader($header)
+ ->setFooter(array(
+ $box,
+ ));
return $this->newPage()
->setTitle($title)
->setCrumbs($crumbs)
- ->appendChild(
- array(
- $box,
- ));
+ ->appendChild($view);
+
}
}
diff --git a/src/applications/almanac/controller/AlmanacServiceEditController.php b/src/applications/almanac/controller/AlmanacServiceEditController.php
--- a/src/applications/almanac/controller/AlmanacServiceEditController.php
+++ b/src/applications/almanac/controller/AlmanacServiceEditController.php
@@ -75,8 +75,12 @@
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addTextCrumb(pht('Create Service'));
+ $crumbs->setBorder(true);
$title = pht('Choose Service Type');
+ $header = id(new PHUIHeaderView())
+ ->setHeader(pht('Create Service'))
+ ->setHeaderIcon('fa-plus-square');
$form = id(new AphrontFormView())
->setUser($viewer)
@@ -88,13 +92,21 @@
$box = id(new PHUIObjectBoxView())
->setFormErrors($errors)
- ->setHeaderText($title)
+ ->setHeaderText(pht('Service'))
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setForm($form);
+ $view = id(new PHUITwoColumnView())
+ ->setHeader($header)
+ ->setFooter(array(
+ $box,
+ ));
+
return $this->newPage()
->setTitle($title)
->setCrumbs($crumbs)
- ->appendChild($box);
+ ->appendChild($view);
+
}
}

File Metadata

Mime Type
text/plain
Expires
Thu, Dec 26, 10:43 AM (11 h, 54 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6927833
Default Alt Text
D15527.id37431.diff (4 KB)

Event Timeline

Phabricator · Built by Phacility