Files F14417538

D18999.id45577.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D18999.id45577.diff
View Options

	diff --git a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
	--- a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
	+++ b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
	@@ -1095,13 +1095,6 @@
	// We are the Herald editor, so stop work here and return the updated
	// transactions.
	return $xactions;
	- } else if ($this->getIsInverseEdgeEditor()) {
	- // If we're applying inverse edge transactions, don't trigger Herald.
	- // From a product perspective, the current set of inverse edges (most
	- // often, mentions) aren't things users would expect to trigger Herald.
	- // From a technical perspective, objects loaded by the inverse editor may
	- // not have enough data to execute rules. At least for now, just stop
	- // Herald from executing when applying inverse edges.
	} else if ($this->shouldApplyHeraldRules($object, $xactions)) {
	// We are not the Herald editor, so try to apply Herald rules.
	$herald_xactions = $this->applyHeraldRules($object, $xactions);

File Metadata

Mime Type: text/plain
Expires: Thu, Dec 26, 1:45 AM (11 h, 31 m)
Storage Engine: blob
Storage Format: Encrypted (AES-256-CBC)
Storage Handle: 6926431
Default Alt Text: D18999.id45577.diff (1 KB)

Event Timeline