Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14414818
D20206.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D20206.diff
View Options
diff --git a/src/applications/auth/provider/PhabricatorFacebookAuthProvider.php b/src/applications/auth/provider/PhabricatorFacebookAuthProvider.php
--- a/src/applications/auth/provider/PhabricatorFacebookAuthProvider.php
+++ b/src/applications/auth/provider/PhabricatorFacebookAuthProvider.php
@@ -47,6 +47,14 @@
return 'Facebook';
}
+ protected function getContentSecurityPolicyFormActions() {
+ return array(
+ // See T13254. After login with a mobile device, Facebook may redirect
+ // to the mobile site.
+ 'https://m.facebook.com/',
+ );
+ }
+
public function readFormValuesFromProvider() {
$require_secure = $this->getProviderConfig()->getProperty(
self::KEY_REQUIRE_SECURE);
@@ -114,15 +122,4 @@
return parent::renderConfigPropertyTransactionTitle($xaction);
}
- public static function getFacebookApplicationID() {
- $providers = PhabricatorAuthProvider::getAllProviders();
- $fb_provider = idx($providers, 'facebook:facebook.com');
- if (!$fb_provider) {
- return null;
- }
-
- return $fb_provider->getProviderConfig()->getProperty(
- self::PROPERTY_APP_ID);
- }
-
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Wed, Dec 25, 4:16 PM (10 h, 18 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6927047
Default Alt Text
D20206.diff (1 KB)
Attached To
Mode
D20206: Fix Facebook login on mobile violating CSP after form redirect
Attached
Detach File
Event Timeline
Log In to Comment