Page MenuHomePhabricator
Files F14412896

D20560.diff
No OneTemporary
Actions

D20560.diff
View Options

diff --git a/src/applications/config/option/PhabricatorCoreConfigOptions.php b/src/applications/config/option/PhabricatorCoreConfigOptions.php
--- a/src/applications/config/option/PhabricatorCoreConfigOptions.php
+++ b/src/applications/config/option/PhabricatorCoreConfigOptions.php
@@ -54,6 +54,20 @@
EOREMARKUP
));
+ $timezone_description = $this->deformat(pht(<<<EOREMARKUP
+PHP date functions will emit a warning if they are called when no default
+server timezone is configured.
+
+Usually, you configure a default timezone in `php.ini` by setting the
+configuration value `date.timezone`.
+
+If you prefer, you can configure a default timezone here instead. To configure
+a default timezone, select a timezone from the
+[[ %s | PHP List of Supported Timezones ]].
+EOREMARKUP
+,
+ 'https://php.net/manual/timezones.php'));
+
return array(
$this->newOption('phabricator.base-uri', 'string', null)
@@ -96,14 +110,7 @@
$this->newOption('phabricator.timezone', 'string', null)
->setSummary(
pht('The timezone Phabricator should use.'))
- ->setDescription(
- pht(
- "PHP requires that you set a timezone in your php.ini before ".
- "using date functions, or it will emit a warning. If this isn't ".
- "possible (for instance, because you are using HPHP) you can set ".
- "some valid constant for %s here and Phabricator will set it on ".
- "your behalf, silencing the warning.",
- 'date_default_timezone_set()'))
+ ->setDescription($timezone_description)
->addExample('America/New_York', pht('US East (EDT)'))
->addExample('America/Chicago', pht('US Central (CDT)'))
->addExample('America/Boise', pht('US Mountain (MDT)'))
@@ -302,12 +309,10 @@
if (!$ok) {
throw new PhabricatorConfigValidationException(
pht(
- "Config option '%s' is invalid. The timezone identifier must ".
- "be a valid timezone identifier recognized by PHP, like '%s'. "."
- You can find a list of valid identifiers here: %s",
+ 'Config option "%s" is invalid. The timezone identifier must '.
+ 'be a valid timezone identifier recognized by PHP, like "%s".',
$key,
- 'America/Los_Angeles',
- 'http://php.net/manual/timezones.php'));
+ 'America/Los_Angeles'));
}
}
}

File Metadata

Mime Type
text/plain
Expires
Wed, Dec 25, 1:33 PM (10 h, 57 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6926484
Default Alt Text
D20560.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility