Page MenuHomePhabricator
Files F14410948

D15569.diff
No OneTemporary
Actions

D15569.diff
View Options

diff --git a/src/applications/meta/controller/PhabricatorApplicationDetailViewController.php b/src/applications/meta/controller/PhabricatorApplicationDetailViewController.php
--- a/src/applications/meta/controller/PhabricatorApplicationDetailViewController.php
+++ b/src/applications/meta/controller/PhabricatorApplicationDetailViewController.php
@@ -123,8 +123,7 @@
PhabricatorApplication $application) {
$viewer = $this->getViewer();
- $properties = id(new PHUIPropertyListView())
- ->setStacked(true);
+ $properties = id(new PHUIPropertyListView());
$header = id(new PHUIHeaderView())
->setHeader(pht('POLICIES'))
diff --git a/src/applications/meta/controller/PhabricatorApplicationEditController.php b/src/applications/meta/controller/PhabricatorApplicationEditController.php
--- a/src/applications/meta/controller/PhabricatorApplicationEditController.php
+++ b/src/applications/meta/controller/PhabricatorApplicationEditController.php
@@ -171,22 +171,27 @@
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addTextCrumb($application->getName(), $view_uri);
$crumbs->addTextCrumb(pht('Edit Policies'));
+ $crumbs->setBorder(true);
$header = id(new PHUIHeaderView())
- ->setHeader(pht('Edit Policies: %s', $application->getName()));
+ ->setHeader(pht('Edit Policies: %s', $application->getName()))
+ ->setHeaderIcon('fa-pencil');
$object_box = id(new PHUIObjectBoxView())
- ->setHeader($header)
+ ->setHeaderText(pht('Policies'))
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setForm($form);
- return $this->buildApplicationPage(
- array(
- $crumbs,
+ $view = id(new PHUITwoColumnView())
+ ->setHeader($header)
+ ->setFooter(array(
$object_box,
- ),
- array(
- 'title' => $title,
));
+
+ return $this->newPage()
+ ->setTitle($title)
+ ->setCrumbs($crumbs)
+ ->appendChild($view);
}
}
diff --git a/src/applications/meta/controller/PhabricatorApplicationEmailCommandsController.php b/src/applications/meta/controller/PhabricatorApplicationEmailCommandsController.php
--- a/src/applications/meta/controller/PhabricatorApplicationEmailCommandsController.php
+++ b/src/applications/meta/controller/PhabricatorApplicationEmailCommandsController.php
@@ -137,14 +137,10 @@
->appendChild($info_view)
->appendChild($content_box);
- return $this->buildApplicationPage(
- array(
- $crumbs,
- $document,
- ),
- array(
- 'title' => $title,
- ));
+ return $this->newPage()
+ ->setTitle($title)
+ ->setCrumbs($crumbs)
+ ->appendChild($document);
}
diff --git a/src/applications/meta/controller/PhabricatorApplicationPanelController.php b/src/applications/meta/controller/PhabricatorApplicationPanelController.php
--- a/src/applications/meta/controller/PhabricatorApplicationPanelController.php
+++ b/src/applications/meta/controller/PhabricatorApplicationPanelController.php
@@ -59,9 +59,14 @@
public function buildPanelPage(
PhabricatorApplicationConfigurationPanel $panel,
- $content,
- array $options) {
- return $this->buildApplicationPage($content, $options);
+ $title,
+ $crumbs,
+ $content) {
+
+ return $this->newPage()
+ ->setTitle($title)
+ ->setCrumbs($crumbs)
+ ->appendChild($content);
}
}
diff --git a/src/applications/metamta/applicationpanel/PhabricatorMetaMTAApplicationEmailPanel.php b/src/applications/metamta/applicationpanel/PhabricatorMetaMTAApplicationEmailPanel.php
--- a/src/applications/metamta/applicationpanel/PhabricatorMetaMTAApplicationEmailPanel.php
+++ b/src/applications/metamta/applicationpanel/PhabricatorMetaMTAApplicationEmailPanel.php
@@ -37,6 +37,7 @@
$box = id(new PHUIObjectBoxView())
->setHeader($header)
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setTable($table);
return $box;
@@ -81,10 +82,12 @@
$crumbs = $controller->buildPanelCrumbs($this);
$crumbs->addTextCrumb(pht('Edit Application Emails'));
+ $crumbs->setBorder(true);
$header = id(new PHUIHeaderView())
->setHeader(pht('Edit Application Emails: %s', $application->getName()))
- ->setSubheader($application->getAppEmailBlurb());
+ ->setSubheader($application->getAppEmailBlurb())
+ ->setHeaderIcon('fa-pencil');
$icon = id(new PHUIIconView())
->setIcon('fa-plus');
@@ -97,20 +100,20 @@
$header->addActionLink($button);
$object_box = id(new PHUIObjectBoxView())
- ->setHeader($header)
+ ->setHeaderText(pht('Emails'))
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setTable($table);
$title = $application->getName();
+ $view = id(new PHUITwoColumnView())
+ ->setHeader($header)
+ ->setFooter($object_box);
return $controller->buildPanelPage(
$this,
- array(
- $crumbs,
- $object_box,
- ),
- array(
- 'title' => $title,
- ));
+ $title,
+ $crumbs,
+ $view);
}
private function returnNewAddressResponse(

File Metadata

Mime Type
text/plain
Expires
Wed, Dec 25, 8:25 AM (10 h, 22 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6925616
Default Alt Text
D15569.diff (5 KB)

Event Timeline

Phabricator · Built by Phacility