Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14397754
D17896.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
2 KB
Referenced Files
None
Subscribers
None
D17896.diff
View Options
diff --git a/src/applications/project/controller/PhabricatorProjectMembersViewController.php b/src/applications/project/controller/PhabricatorProjectMembersViewController.php
--- a/src/applications/project/controller/PhabricatorProjectMembersViewController.php
+++ b/src/applications/project/controller/PhabricatorProjectMembersViewController.php
@@ -26,13 +26,15 @@
->setUser($viewer)
->setProject($project)
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
- ->setUserPHIDs($project->getMemberPHIDs());
+ ->setUserPHIDs($project->getMemberPHIDs())
+ ->setShowNote(true);
$watcher_list = id(new PhabricatorProjectWatcherListView())
->setUser($viewer)
->setProject($project)
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
- ->setUserPHIDs($project->getWatcherPHIDs());
+ ->setUserPHIDs($project->getWatcherPHIDs())
+ ->setShowNote(true);
$nav = $this->getProfileMenu();
$nav->selectFilter(PhabricatorProject::ITEM_MEMBERS);
diff --git a/src/applications/project/view/PhabricatorProjectUserListView.php b/src/applications/project/view/PhabricatorProjectUserListView.php
--- a/src/applications/project/view/PhabricatorProjectUserListView.php
+++ b/src/applications/project/view/PhabricatorProjectUserListView.php
@@ -6,6 +6,7 @@
private $userPHIDs;
private $limit;
private $background;
+ private $showNote;
public function setProject(PhabricatorProject $project) {
$this->project = $project;
@@ -39,6 +40,11 @@
return $this;
}
+ public function setShowNote($show) {
+ $this->showNote = $show;
+ return $this;
+ }
+
abstract protected function canEditList();
abstract protected function getNoDataString();
abstract protected function getRemoveURI($phid);
@@ -136,11 +142,13 @@
->setHeader($header)
->setObjectList($list);
- if ($this->getMembershipNote()) {
- $info = id(new PHUIInfoView())
- ->setSeverity(PHUIInfoView::SEVERITY_PLAIN)
- ->appendChild($this->getMembershipNote());
- $box->setInfoView($info);
+ if ($this->showNote) {
+ if ($this->getMembershipNote()) {
+ $info = id(new PHUIInfoView())
+ ->setSeverity(PHUIInfoView::SEVERITY_PLAIN)
+ ->appendChild($this->getMembershipNote());
+ $box->setInfoView($info);
+ }
}
if ($this->background) {
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Mon, Dec 23, 11:59 AM (3 h, 27 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6919111
Default Alt Text
D17896.diff (2 KB)
Attached To
Mode
D17896: Only show member/watcher notes on Members page in Projects
Attached
Detach File
Event Timeline
Log In to Comment