Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14397242
D15048.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
910 B
Referenced Files
None
Subscribers
None
D15048.diff
View Options
diff --git a/src/applications/project/editor/PhabricatorProjectTransactionEditor.php b/src/applications/project/editor/PhabricatorProjectTransactionEditor.php
--- a/src/applications/project/editor/PhabricatorProjectTransactionEditor.php
+++ b/src/applications/project/editor/PhabricatorProjectTransactionEditor.php
@@ -756,12 +756,17 @@
}
private function removeSlugs(PhabricatorProject $project, array $slugs) {
- $slugs = $this->normalizeSlugs($slugs);
-
if (!$slugs) {
return;
}
+ // We're going to try to delete both the literal and normalized versions
+ // of all slugs. This allows us to destroy old slugs that are no longer
+ // valid.
+ foreach ($this->normalizeSlugs($slugs) as $slug) {
+ $slugs[] = $slug;
+ }
+
$objects = id(new PhabricatorProjectSlug())->loadAllWhere(
'projectPHID = %s AND slug IN (%Ls)',
$project->getPHID(),
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Mon, Dec 23, 9:57 AM (17 h, 44 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6921062
Default Alt Text
D15048.diff (910 B)
Attached To
Mode
D15048: When removing project slugs, try to remove raw slugs too so we can remove old/invalid slugs
Attached
Detach File
Event Timeline
Log In to Comment