Page MenuHomePhabricator
Files F14394444

D13380.diff
No OneTemporary
Actions

D13380.diff
View Options

diff --git a/src/applications/differential/conduit/DifferentialCreateDiffConduitAPIMethod.php b/src/applications/differential/conduit/DifferentialCreateDiffConduitAPIMethod.php
--- a/src/applications/differential/conduit/DifferentialCreateDiffConduitAPIMethod.php
+++ b/src/applications/differential/conduit/DifferentialCreateDiffConduitAPIMethod.php
@@ -160,7 +160,8 @@
return array(
'diffid' => $diff->getID(),
- 'uri' => $uri,
+ 'phid' => $diff->getPHID(),
+ 'uri' => $uri,
);
}
diff --git a/src/applications/harbormaster/conduit/HarbormasterSendMessageConduitAPIMethod.php b/src/applications/harbormaster/conduit/HarbormasterSendMessageConduitAPIMethod.php
--- a/src/applications/harbormaster/conduit/HarbormasterSendMessageConduitAPIMethod.php
+++ b/src/applications/harbormaster/conduit/HarbormasterSendMessageConduitAPIMethod.php
@@ -18,7 +18,9 @@
return array(
'buildTargetPHID' => 'required phid',
- 'type' => 'required '.$type_const,
+ 'lint' => 'optional list<wild>',
+ 'unit' => 'optional list<wild>',
+ 'type' => 'required '.$type_const,
);
}
@@ -40,10 +42,31 @@
throw new Exception(pht('No such build target!'));
}
- $message = HarbormasterBuildMessage::initializeNewMessage($viewer)
+ $save = array();
+
+ $lint_messages = $request->getValue('lint', array());
+ foreach ($lint_messages as $lint) {
+ $save[] = HarbormasterBuildLintMessage::newFromDictionary(
+ $build_target,
+ $lint);
+ }
+
+ $unit_messages = $request->getValue('unit', array());
+ foreach ($unit_messages as $unit) {
+ $save[] = HarbormasterBuildUnitMessage::newFromDictionary(
+ $build_target,
+ $unit);
+ }
+
+ $save[] = HarbormasterBuildMessage::initializeNewMessage($viewer)
->setBuildTargetPHID($build_target->getPHID())
- ->setType($message_type)
- ->save();
+ ->setType($message_type);
+
+ $build_target->openTransaction();
+ foreach ($save as $object) {
+ $object->save();
+ }
+ $build_target->saveTransaction();
// If the build has completely paused because all steps are blocked on
// waiting targets, this will resume it.
diff --git a/src/applications/harbormaster/controller/HarbormasterBuildableViewController.php b/src/applications/harbormaster/controller/HarbormasterBuildableViewController.php
--- a/src/applications/harbormaster/controller/HarbormasterBuildableViewController.php
+++ b/src/applications/harbormaster/controller/HarbormasterBuildableViewController.php
@@ -248,7 +248,13 @@
$build_list->addItem($item);
}
- return $build_list;
+ $build_list->setFlush(true);
+
+ $box = id(new PHUIObjectBoxView())
+ ->setHeaderText(pht('Builds'))
+ ->appendChild($build_list);
+
+ return $box;
}
}

File Metadata

Mime Type
text/plain
Expires
Mon, Dec 23, 2:02 AM (17 h, 32 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6920215
Default Alt Text
D13380.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility