Page MenuHomePhabricator
Files F14386663

D15270.id36844.diff
No OneTemporary
Actions

D15270.id36844.diff
View Options

diff --git a/src/applications/project/controller/PhabricatorProjectBoardViewController.php b/src/applications/project/controller/PhabricatorProjectBoardViewController.php
--- a/src/applications/project/controller/PhabricatorProjectBoardViewController.php
+++ b/src/applications/project/controller/PhabricatorProjectBoardViewController.php
@@ -692,7 +692,7 @@
->setName(pht('Add Column'))
->setHref($add_uri)
->setDisabled(!$can_edit)
- ->setWorkflow(!$can_edit);
+ ->setWorkflow(true);
$manage_items[] = id(new PhabricatorActionView())
->setIcon('fa-exchange')
diff --git a/src/applications/project/controller/PhabricatorProjectColumnDetailController.php b/src/applications/project/controller/PhabricatorProjectColumnDetailController.php
--- a/src/applications/project/controller/PhabricatorProjectColumnDetailController.php
+++ b/src/applications/project/controller/PhabricatorProjectColumnDetailController.php
@@ -103,7 +103,7 @@
->setIcon('fa-pencil')
->setHref($this->getApplicationURI($base_uri.'edit/'.$id.'/'))
->setDisabled(!$can_edit)
- ->setWorkflow(!$can_edit));
+ ->setWorkflow(true));
return $actions;
}
diff --git a/src/applications/project/controller/PhabricatorProjectColumnEditController.php b/src/applications/project/controller/PhabricatorProjectColumnEditController.php
--- a/src/applications/project/controller/PhabricatorProjectColumnEditController.php
+++ b/src/applications/project/controller/PhabricatorProjectColumnEditController.php
@@ -107,7 +107,7 @@
}
}
- $form = id(new AphrontFormView())
+ $form = id(new PHUIFormLayoutView())
->setUser($request->getUser());
if (!$column->getProxy()) {
@@ -136,21 +136,14 @@
$submit = pht('Save Column');
}
- $form->appendChild(
- id(new AphrontFormSubmitControl())
- ->setValue($submit)
- ->addCancelButton($view_uri));
-
- $form_box = id(new PHUIObjectBoxView())
- ->setHeaderText($title)
+ return $this->newDialog()
+ ->setWidth(AphrontDialogView::WIDTH_FORM)
+ ->setTitle($title)
+ ->appendChild($form)
->setValidationException($validation_exception)
- ->setForm($form);
+ ->setDisableWorkflowOnCancel(true)
+ ->addCancelButton($view_uri)
+ ->addSubmitButton($submit);
- $nav = $this->getProfileMenu();
-
- return $this->newPage()
- ->setTitle($title)
- ->setNavigation($nav)
- ->appendChild($form_box);
}
}

File Metadata

Mime Type
text/plain
Expires
Sun, Dec 22, 2:00 PM (3 h, 25 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6918447
Default Alt Text
D15270.id36844.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility