Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14383122
D11146.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
17 KB
Referenced Files
None
Subscribers
None
D11146.diff
View Options
diff --git a/src/applications/audit/storage/PhabricatorAuditTransaction.php b/src/applications/audit/storage/PhabricatorAuditTransaction.php
--- a/src/applications/audit/storage/PhabricatorAuditTransaction.php
+++ b/src/applications/audit/storage/PhabricatorAuditTransaction.php
@@ -258,7 +258,7 @@
return parent::getTitle();
}
- public function getTitleForFeed(PhabricatorFeedStory $story) {
+ public function getTitleForFeed() {
$old = $this->getOldValue();
$new = $this->getNewValue();
@@ -375,7 +375,7 @@
}
- return parent::getTitleForFeed($story);
+ return parent::getTitleForFeed();
}
public function getBodyForFeed(PhabricatorFeedStory $story) {
diff --git a/src/applications/config/storage/PhabricatorConfigTransaction.php b/src/applications/config/storage/PhabricatorConfigTransaction.php
--- a/src/applications/config/storage/PhabricatorConfigTransaction.php
+++ b/src/applications/config/storage/PhabricatorConfigTransaction.php
@@ -55,7 +55,7 @@
return parent::getTitle();
}
- public function getTitleForFeed(PhabricatorFeedStory $story = null) {
+ public function getTitleForFeed() {
$author_phid = $this->getAuthorPHID();
$old = $this->getOldValue();
diff --git a/src/applications/dashboard/storage/PhabricatorDashboardPanelTransaction.php b/src/applications/dashboard/storage/PhabricatorDashboardPanelTransaction.php
--- a/src/applications/dashboard/storage/PhabricatorDashboardPanelTransaction.php
+++ b/src/applications/dashboard/storage/PhabricatorDashboardPanelTransaction.php
@@ -52,7 +52,7 @@
return parent::getTitle();
}
- public function getTitleForFeed(PhabricatorFeedStory $story) {
+ public function getTitleForFeed() {
$author_phid = $this->getAuthorPHID();
$object_phid = $this->getObjectPHID();
@@ -92,7 +92,7 @@
}
}
- return parent::getTitleForFeed($story);
+ return parent::getTitleForFeed();
}
public function getColor() {
diff --git a/src/applications/dashboard/storage/PhabricatorDashboardTransaction.php b/src/applications/dashboard/storage/PhabricatorDashboardTransaction.php
--- a/src/applications/dashboard/storage/PhabricatorDashboardTransaction.php
+++ b/src/applications/dashboard/storage/PhabricatorDashboardTransaction.php
@@ -42,7 +42,7 @@
return parent::getTitle();
}
- public function getTitleForFeed(PhabricatorFeedStory $story) {
+ public function getTitleForFeed() {
$author_phid = $this->getAuthorPHID();
$object_phid = $this->getObjectPHID();
@@ -70,7 +70,7 @@
}
}
- return parent::getTitleForFeed($story);
+ return parent::getTitleForFeed();
}
public function getColor() {
diff --git a/src/applications/differential/customfield/DifferentialBlameRevisionField.php b/src/applications/differential/customfield/DifferentialBlameRevisionField.php
--- a/src/applications/differential/customfield/DifferentialBlameRevisionField.php
+++ b/src/applications/differential/customfield/DifferentialBlameRevisionField.php
@@ -74,8 +74,7 @@
}
public function getApplicationTransactionTitleForFeed(
- PhabricatorApplicationTransaction $xaction,
- PhabricatorFeedStory $story) {
+ PhabricatorApplicationTransaction $xaction) {
$object_phid = $xaction->getObjectPHID();
$author_phid = $xaction->getAuthorPHID();
diff --git a/src/applications/differential/customfield/DifferentialRepositoryField.php b/src/applications/differential/customfield/DifferentialRepositoryField.php
--- a/src/applications/differential/customfield/DifferentialRepositoryField.php
+++ b/src/applications/differential/customfield/DifferentialRepositoryField.php
@@ -99,8 +99,7 @@
}
public function getApplicationTransactionTitleForFeed(
- PhabricatorApplicationTransaction $xaction,
- PhabricatorFeedStory $story) {
+ PhabricatorApplicationTransaction $xaction) {
$object_phid = $xaction->getObjectPHID();
$author_phid = $xaction->getAuthorPHID();
diff --git a/src/applications/differential/customfield/DifferentialRevertPlanField.php b/src/applications/differential/customfield/DifferentialRevertPlanField.php
--- a/src/applications/differential/customfield/DifferentialRevertPlanField.php
+++ b/src/applications/differential/customfield/DifferentialRevertPlanField.php
@@ -103,8 +103,7 @@
}
public function getApplicationTransactionTitleForFeed(
- PhabricatorApplicationTransaction $xaction,
- PhabricatorFeedStory $story) {
+ PhabricatorApplicationTransaction $xaction) {
$object_phid = $xaction->getObjectPHID();
$author_phid = $xaction->getAuthorPHID();
diff --git a/src/applications/differential/customfield/DifferentialSummaryField.php b/src/applications/differential/customfield/DifferentialSummaryField.php
--- a/src/applications/differential/customfield/DifferentialSummaryField.php
+++ b/src/applications/differential/customfield/DifferentialSummaryField.php
@@ -58,8 +58,7 @@
}
public function getApplicationTransactionTitleForFeed(
- PhabricatorApplicationTransaction $xaction,
- PhabricatorFeedStory $story) {
+ PhabricatorApplicationTransaction $xaction) {
$object_phid = $xaction->getObjectPHID();
$author_phid = $xaction->getAuthorPHID();
diff --git a/src/applications/differential/customfield/DifferentialTestPlanField.php b/src/applications/differential/customfield/DifferentialTestPlanField.php
--- a/src/applications/differential/customfield/DifferentialTestPlanField.php
+++ b/src/applications/differential/customfield/DifferentialTestPlanField.php
@@ -72,8 +72,7 @@
}
public function getApplicationTransactionTitleForFeed(
- PhabricatorApplicationTransaction $xaction,
- PhabricatorFeedStory $story) {
+ PhabricatorApplicationTransaction $xaction) {
$object_phid = $xaction->getObjectPHID();
$author_phid = $xaction->getAuthorPHID();
diff --git a/src/applications/differential/customfield/DifferentialTitleField.php b/src/applications/differential/customfield/DifferentialTitleField.php
--- a/src/applications/differential/customfield/DifferentialTitleField.php
+++ b/src/applications/differential/customfield/DifferentialTitleField.php
@@ -75,8 +75,7 @@
}
public function getApplicationTransactionTitleForFeed(
- PhabricatorApplicationTransaction $xaction,
- PhabricatorFeedStory $story) {
+ PhabricatorApplicationTransaction $xaction) {
$object_phid = $xaction->getObjectPHID();
$author_phid = $xaction->getAuthorPHID();
diff --git a/src/applications/differential/storage/DifferentialTransaction.php b/src/applications/differential/storage/DifferentialTransaction.php
--- a/src/applications/differential/storage/DifferentialTransaction.php
+++ b/src/applications/differential/storage/DifferentialTransaction.php
@@ -326,7 +326,7 @@
return parent::renderExtraInformationLink();
}
- public function getTitleForFeed(PhabricatorFeedStory $story) {
+ public function getTitleForFeed() {
$author_phid = $this->getAuthorPHID();
$object_phid = $this->getObjectPHID();
@@ -452,7 +452,7 @@
}
}
- return parent::getTitleForFeed($story);
+ return parent::getTitleForFeed();
}
public function getIcon() {
diff --git a/src/applications/fund/storage/FundInitiativeTransaction.php b/src/applications/fund/storage/FundInitiativeTransaction.php
--- a/src/applications/fund/storage/FundInitiativeTransaction.php
+++ b/src/applications/fund/storage/FundInitiativeTransaction.php
@@ -133,7 +133,7 @@
return parent::getTitle();
}
- public function getTitleForFeed(PhabricatorFeedStory $story) {
+ public function getTitleForFeed() {
$author_phid = $this->getAuthorPHID();
$object_phid = $this->getObjectPHID();
@@ -197,7 +197,7 @@
$this->renderHandleLink($object_phid));
}
- return parent::getTitleForFeed($story);
+ return parent::getTitleForFeed();
}
public function getMailTags() {
diff --git a/src/applications/macro/storage/PhabricatorMacroTransaction.php b/src/applications/macro/storage/PhabricatorMacroTransaction.php
--- a/src/applications/macro/storage/PhabricatorMacroTransaction.php
+++ b/src/applications/macro/storage/PhabricatorMacroTransaction.php
@@ -124,7 +124,7 @@
return parent::getTitle();
}
- public function getTitleForFeed(PhabricatorFeedStory $story) {
+ public function getTitleForFeed() {
$author_phid = $this->getAuthorPHID();
$object_phid = $this->getObjectPHID();
@@ -201,7 +201,7 @@
}
- return parent::getTitleForFeed($story);
+ return parent::getTitleForFeed();
}
public function getActionName() {
diff --git a/src/applications/maniphest/storage/ManiphestTransaction.php b/src/applications/maniphest/storage/ManiphestTransaction.php
--- a/src/applications/maniphest/storage/ManiphestTransaction.php
+++ b/src/applications/maniphest/storage/ManiphestTransaction.php
@@ -554,7 +554,7 @@
return parent::getTitle();
}
- public function getTitleForFeed(PhabricatorFeedStory $story) {
+ public function getTitleForFeed() {
$author_phid = $this->getAuthorPHID();
$object_phid = $this->getObjectPHID();
@@ -711,7 +711,7 @@
// code in the parent;
$clone = clone $this;
$clone->setTransactionType(PhabricatorTransactions::TYPE_EDGE);
- return $clone->getTitleForFeed($story);
+ return $clone->getTitleForFeed();
case self::TYPE_ATTACH:
$old = nonempty($old, array());
@@ -773,7 +773,7 @@
}
- return parent::getTitleForFeed($story);
+ return parent::getTitleForFeed();
}
public function hasChangeDetails() {
diff --git a/src/applications/paste/storage/PhabricatorPasteTransaction.php b/src/applications/paste/storage/PhabricatorPasteTransaction.php
--- a/src/applications/paste/storage/PhabricatorPasteTransaction.php
+++ b/src/applications/paste/storage/PhabricatorPasteTransaction.php
@@ -90,7 +90,7 @@
return parent::getTitle();
}
- public function getTitleForFeed(PhabricatorFeedStory $story) {
+ public function getTitleForFeed() {
$author_phid = $this->getAuthorPHID();
$object_phid = $this->getObjectPHID();
@@ -126,7 +126,7 @@
break;
}
- return parent::getTitleForFeed($story);
+ return parent::getTitleForFeed();
}
public function getColor() {
diff --git a/src/applications/pholio/storage/PholioTransaction.php b/src/applications/pholio/storage/PholioTransaction.php
--- a/src/applications/pholio/storage/PholioTransaction.php
+++ b/src/applications/pholio/storage/PholioTransaction.php
@@ -209,7 +209,7 @@
return parent::getTitle();
}
- public function getTitleForFeed(PhabricatorFeedStory $story) {
+ public function getTitleForFeed() {
$author_phid = $this->getAuthorPHID();
$object_phid = $this->getObjectPHID();
@@ -278,7 +278,7 @@
break;
}
- return parent::getTitleForFeed($story);
+ return parent::getTitleForFeed();
}
public function getBodyForFeed(PhabricatorFeedStory $story) {
diff --git a/src/applications/phriction/storage/PhrictionTransaction.php b/src/applications/phriction/storage/PhrictionTransaction.php
--- a/src/applications/phriction/storage/PhrictionTransaction.php
+++ b/src/applications/phriction/storage/PhrictionTransaction.php
@@ -214,7 +214,7 @@
return parent::getTitle();
}
- public function getTitleForFeed(PhabricatorFeedStory $story) {
+ public function getTitleForFeed() {
$author_phid = $this->getAuthorPHID();
$object_phid = $this->getObjectPHID();
@@ -250,7 +250,7 @@
$this->renderHandleLink($object_phid));
}
- return parent::getTitleForFeed($story);
+ return parent::getTitleForFeed();
}
public function hasChangeDetails() {
diff --git a/src/applications/ponder/storage/PonderAnswerTransaction.php b/src/applications/ponder/storage/PonderAnswerTransaction.php
--- a/src/applications/ponder/storage/PonderAnswerTransaction.php
+++ b/src/applications/ponder/storage/PonderAnswerTransaction.php
@@ -60,7 +60,7 @@
return parent::getTitle();
}
- public function getTitleForFeed(PhabricatorFeedStory $story) {
+ public function getTitleForFeed() {
$author_phid = $this->getAuthorPHID();
$object_phid = $this->getObjectPHID();
@@ -72,7 +72,7 @@
$this->renderHandleLink($object_phid));
}
- return parent::getTitleForFeed($story);
+ return parent::getTitleForFeed();
}
public function getBodyForFeed(PhabricatorFeedStory $story) {
diff --git a/src/applications/ponder/storage/PonderQuestionTransaction.php b/src/applications/ponder/storage/PonderQuestionTransaction.php
--- a/src/applications/ponder/storage/PonderQuestionTransaction.php
+++ b/src/applications/ponder/storage/PonderQuestionTransaction.php
@@ -202,7 +202,7 @@
return parent::shouldHide();
}
- public function getTitleForFeed(PhabricatorFeedStory $story) {
+ public function getTitleForFeed() {
$author_phid = $this->getAuthorPHID();
$object_phid = $this->getObjectPHID();
@@ -250,7 +250,7 @@
}
}
- return parent::getTitleForFeed($story);
+ return parent::getTitleForFeed();
}
public function getBodyForFeed(PhabricatorFeedStory $story) {
diff --git a/src/applications/releeph/storage/ReleephProductTransaction.php b/src/applications/releeph/storage/ReleephProductTransaction.php
--- a/src/applications/releeph/storage/ReleephProductTransaction.php
+++ b/src/applications/releeph/storage/ReleephProductTransaction.php
@@ -70,7 +70,7 @@
return parent::getTitle();
}
- public function getTitleForFeed(PhabricatorFeedStory $story) {
+ public function getTitleForFeed() {
$author_phid = $this->getAuthorPHID();
$object_phid = $this->getObjectPHID();
@@ -93,7 +93,7 @@
break;
}
- return parent::getTitleForFeed($story);
+ return parent::getTitleForFeed();
}
public function getNoEffectDescription() {
diff --git a/src/applications/transactions/feed/PhabricatorApplicationTransactionFeedStory.php b/src/applications/transactions/feed/PhabricatorApplicationTransactionFeedStory.php
--- a/src/applications/transactions/feed/PhabricatorApplicationTransactionFeedStory.php
+++ b/src/applications/transactions/feed/PhabricatorApplicationTransactionFeedStory.php
@@ -75,7 +75,7 @@
$xaction = $this->getPrimaryTransaction();
$xaction->setHandles($this->getHandles());
- $view->setTitle($xaction->getTitleForFeed($this));
+ $view->setTitle($xaction->getTitleForFeed());
foreach ($xaction_phids as $xaction_phid) {
$secondary_xaction = $this->getObject($xaction_phid);
@@ -99,7 +99,7 @@
$new_target = PhabricatorApplicationTransaction::TARGET_TEXT;
$xaction->setRenderingTarget($new_target);
$xaction->setHandles($this->getHandles());
- $text = $xaction->getTitleForFeed($this);
+ $text = $xaction->getTitleForFeed();
$xaction->setRenderingTarget($old_target);
return $text;
}
diff --git a/src/applications/transactions/storage/PhabricatorApplicationTransaction.php b/src/applications/transactions/storage/PhabricatorApplicationTransaction.php
--- a/src/applications/transactions/storage/PhabricatorApplicationTransaction.php
+++ b/src/applications/transactions/storage/PhabricatorApplicationTransaction.php
@@ -728,7 +728,7 @@
}
}
- public function getTitleForFeed(PhabricatorFeedStory $story) {
+ public function getTitleForFeed() {
$author_phid = $this->getAuthorPHID();
$object_phid = $this->getObjectPHID();
@@ -802,7 +802,7 @@
case PhabricatorTransactions::TYPE_CUSTOMFIELD:
$field = $this->getTransactionCustomField();
if ($field) {
- return $field->getApplicationTransactionTitleForFeed($this, $story);
+ return $field->getApplicationTransactionTitleForFeed($this);
} else {
return pht(
'%s edited a custom field on %s.',
@@ -1102,7 +1102,7 @@
if ($publisher->getRenderWithImpliedContext()) {
$text[] = $xaction->getTitle();
} else {
- $text[] = $xaction->getTitleForFeed($story);
+ $text[] = $xaction->getTitleForFeed();
}
$xaction->setRenderingTarget($old_target);
diff --git a/src/infrastructure/customfield/field/PhabricatorCustomField.php b/src/infrastructure/customfield/field/PhabricatorCustomField.php
--- a/src/infrastructure/customfield/field/PhabricatorCustomField.php
+++ b/src/infrastructure/customfield/field/PhabricatorCustomField.php
@@ -1003,12 +1003,10 @@
}
public function getApplicationTransactionTitleForFeed(
- PhabricatorApplicationTransaction $xaction,
- PhabricatorFeedStory $story) {
+ PhabricatorApplicationTransaction $xaction) {
if ($this->proxy) {
return $this->proxy->getApplicationTransactionTitleForFeed(
- $xaction,
- $story);
+ $xaction);
}
$author_phid = $xaction->getAuthorPHID();
diff --git a/src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php b/src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php
--- a/src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php
+++ b/src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php
@@ -360,8 +360,7 @@
}
public function getApplicationTransactionTitleForFeed(
- PhabricatorApplicationTransaction $xaction,
- PhabricatorFeedStory $story) {
+ PhabricatorApplicationTransaction $xaction) {
$author_phid = $xaction->getAuthorPHID();
$object_phid = $xaction->getObjectPHID();
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Dec 22, 6:45 AM (21 h, 2 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6917768
Default Alt Text
D11146.diff (17 KB)
Attached To
Mode
D11146: remove unused FeedStory object in getTitleForFeed functions
Attached
Detach File
Event Timeline
Log In to Comment