Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14361773
D15558.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
2 KB
Referenced Files
None
Subscribers
None
D15558.diff
View Options
diff --git a/src/applications/countdown/controller/PhabricatorCountdownEditController.php b/src/applications/countdown/controller/PhabricatorCountdownEditController.php
--- a/src/applications/countdown/controller/PhabricatorCountdownEditController.php
+++ b/src/applications/countdown/controller/PhabricatorCountdownEditController.php
@@ -8,7 +8,6 @@
$id = $request->getURIData('id');
if ($id) {
- $page_title = pht('Edit Countdown');
$countdown = id(new PhabricatorCountdownQuery())
->setViewer($viewer)
->withIDs(array($id))
@@ -28,8 +27,9 @@
$countdown->getPHID(),
PhabricatorProjectObjectHasProjectEdgeType::EDGECONST);
$v_projects = array_reverse($v_projects);
+ $title = pht('Edit Countdown: %s', $countdown->getTitle());
} else {
- $page_title = pht('Create Countdown');
+ $title = pht('Create Countdown');
$countdown = PhabricatorCountdown::initializeNewCountdown($viewer);
$date_value = AphrontFormDateControlValue::newFromEpoch(
$viewer, PhabricatorTime::getNow());
@@ -116,6 +116,7 @@
}
$crumbs = $this->buildApplicationCrumbs();
+ $crumbs->setBorder(true);
$cancel_uri = '/countdown/';
if ($countdown->getID()) {
@@ -123,9 +124,11 @@
$crumbs->addTextCrumb('C'.$countdown->getID(), $cancel_uri);
$crumbs->addTextCrumb(pht('Edit'));
$submit_label = pht('Save Changes');
+ $header_icon = 'fa-pencil';
} else {
$crumbs->addTextCrumb(pht('Create Countdown'));
$submit_label = pht('Create Countdown');
+ $header_icon = 'fa-plus-square';
}
$policies = id(new PhabricatorPolicyQuery())
@@ -180,16 +183,25 @@
->setValue($submit_label));
$form_box = id(new PHUIObjectBoxView())
- ->setHeaderText($page_title)
+ ->setHeaderText(pht('Countdown'))
->setFormErrors($errors)
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setForm($form);
+ $header = id(new PHUIHeaderView())
+ ->setHeader($title)
+ ->setHeaderIcon($header_icon);
+
+ $view = id(new PHUITwoColumnView())
+ ->setHeader($header)
+ ->setFooter($form_box);
+
return $this->newPage()
- ->setTitle($page_title)
+ ->setTitle($title)
->setCrumbs($crumbs)
->appendChild(
array(
- $form_box,
+ $view,
));
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Dec 21, 11:52 AM (17 h, 59 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6913894
Default Alt Text
D15558.diff (2 KB)
Attached To
Mode
D15558: Update Countdown edit page for new UI
Attached
Detach File
Event Timeline
Log In to Comment