Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14353163
D14142.id34174.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D14142.id34174.diff
View Options
diff --git a/src/applications/repository/customfield/PhabricatorCommitTagsField.php b/src/applications/repository/customfield/PhabricatorCommitTagsField.php
--- a/src/applications/repository/customfield/PhabricatorCommitTagsField.php
+++ b/src/applications/repository/customfield/PhabricatorCommitTagsField.php
@@ -29,18 +29,23 @@
'callsign' => $this->getObject()->getRepository()->getCallsign(),
);
- $tags_raw = id(new ConduitCall('diffusion.tagsquery', $params))
- ->setUser($this->getViewer())
- ->execute();
-
- $tags = DiffusionRepositoryTag::newFromConduit($tags_raw);
- if (!$tags) {
- return;
+ try {
+ $tags_raw = id(new ConduitCall('diffusion.tagsquery', $params))
+ ->setUser($this->getViewer())
+ ->execute();
+
+ $tags = DiffusionRepositoryTag::newFromConduit($tags_raw);
+ if (!$tags) {
+ return;
+ }
+ $tag_names = mpull($tags, 'getName');
+ sort($tag_names);
+ $tag_names = implode(', ', $tag_names);
+ } catch (Exception $ex) {
+ $tag_names = pht('<%s: %s>', get_class($ex), $ex->getMessage());
}
- $tag_names = mpull($tags, 'getName');
- sort($tag_names);
- $body->addTextSection(pht('TAGS'), implode(', ', $tag_names));
+ $body->addTextSection(pht('TAGS'), $tag_names);
}
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Fri, Dec 20, 4:25 PM (6 h, 7 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6911105
Default Alt Text
D14142.id34174.diff (1 KB)
Attached To
Mode
D14142: Recover gracefully from Conduit failure when building "Tags" field in commit mail
Attached
Detach File
Event Timeline
Log In to Comment