Page MenuHomePhabricator

D13341.diff
No OneTemporary

D13341.diff

diff --git a/src/applications/drydock/blueprint/DrydockPreallocatedHostBlueprintImplementation.php b/src/applications/drydock/blueprint/DrydockPreallocatedHostBlueprintImplementation.php
--- a/src/applications/drydock/blueprint/DrydockPreallocatedHostBlueprintImplementation.php
+++ b/src/applications/drydock/blueprint/DrydockPreallocatedHostBlueprintImplementation.php
@@ -77,20 +77,7 @@
$cmd = $lease->getInterface('command');
- if ($v_platform !== 'windows') {
- $cmd->execx('mkdir %s', $full_path);
- } else {
- // Windows is terrible. The mkdir command doesn't even support putting
- // the path in quotes. IN QUOTES. ARGUHRGHUGHHGG!! Do some terribly
- // inaccurate sanity checking since we can't safely escape the path.
- if (preg_match('/^[A-Z]\\:\\\\[a-zA-Z0-9\\\\\\ ]/', $full_path) === 0) {
- throw new Exception(
- pht(
- 'Unsafe path detected for Windows platform: "%s".',
- $full_path));
- }
- $cmd->execx('mkdir %C', $full_path);
- }
+ $cmd->execx('mkdir %s', $full_path);
$lease->setAttribute('path', $full_path);
}

File Metadata

Mime Type
text/plain
Expires
Fri, Dec 20, 4:19 AM (21 h, 17 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6909510
Default Alt Text
D13341.diff (1 KB)

Event Timeline