D16169.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D16169.diff
View Options

	diff --git a/src/applications/badges/editor/PhabricatorBadgesEditor.php b/src/applications/badges/editor/PhabricatorBadgesEditor.php
	--- a/src/applications/badges/editor/PhabricatorBadgesEditor.php
	+++ b/src/applications/badges/editor/PhabricatorBadgesEditor.php
	@@ -47,7 +47,7 @@
	case PhabricatorBadgesTransaction::TYPE_ICON:
	return $object->getIcon();
	case PhabricatorBadgesTransaction::TYPE_QUALITY:
	- return $object->getQuality();
	+ return (int)$object->getQuality();
	case PhabricatorBadgesTransaction::TYPE_STATUS:
	return $object->getStatus();
	case PhabricatorBadgesTransaction::TYPE_AWARD:
	diff --git a/src/applications/badges/storage/PhabricatorBadgesTransaction.php b/src/applications/badges/storage/PhabricatorBadgesTransaction.php
	--- a/src/applications/badges/storage/PhabricatorBadgesTransaction.php
	+++ b/src/applications/badges/storage/PhabricatorBadgesTransaction.php
	@@ -105,14 +105,14 @@
	}
	break;
	case self::TYPE_QUALITY:
	+ $qual_new = PhabricatorBadgesQuality::getQualityName($new);
	+ $qual_old = PhabricatorBadgesQuality::getQualityName($old);
	if ($old === null) {
	return pht(
	'%s set the quality for this badge as "%s".',
	$this->renderHandleLink($author_phid),
	$new);
	} else {
	- $qual_new = PhabricatorBadgesQuality::getQualityName($new);
	- $qual_old = PhabricatorBadgesQuality::getQualityName($old);
	return pht(
	'%s updated the quality for this badge from "%s" to "%s".',
	$this->renderHandleLink($author_phid),