Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14325750
D16919.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D16919.diff
View Options
diff --git a/src/applications/harbormaster/customfield/HarbormasterBuildStepCoreCustomField.php b/src/applications/harbormaster/customfield/HarbormasterBuildStepCoreCustomField.php
--- a/src/applications/harbormaster/customfield/HarbormasterBuildStepCoreCustomField.php
+++ b/src/applications/harbormaster/customfield/HarbormasterBuildStepCoreCustomField.php
@@ -43,7 +43,7 @@
'the result for this step. After the result is recorded, the build '.
'plan will resume.'),
'options' => array(
- '' => pht('Continue Build Normally'),
+ 'continue' => pht('Continue Build Normally'),
'wait' => pht('Wait For Message'),
),
);
diff --git a/src/applications/harbormaster/step/HarbormasterBuildStepImplementation.php b/src/applications/harbormaster/step/HarbormasterBuildStepImplementation.php
--- a/src/applications/harbormaster/step/HarbormasterBuildStepImplementation.php
+++ b/src/applications/harbormaster/step/HarbormasterBuildStepImplementation.php
@@ -237,7 +237,8 @@
return false;
}
- return (bool)$target->getDetail('builtin.wait-for-message');
+ $wait = $target->getDetail('builtin.wait-for-message');
+ return ($wait == 'wait');
}
protected function shouldAbort(
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Thu, Dec 19, 2:15 PM (7 h, 28 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6907642
Default Alt Text
D16919.diff (1 KB)
Attached To
Mode
D16919: Allow "Wait for Message" to be unset on build plans
Attached
Detach File
Event Timeline
Log In to Comment