Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14095068
D21526.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
808 B
Referenced Files
None
Subscribers
None
D21526.diff
View Options
diff --git a/src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php b/src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php
--- a/src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php
+++ b/src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php
@@ -318,6 +318,11 @@
'Acquiring write lock for repository "%s"...',
$repository->getDisplayName()));
+ // See T13590. On the HTTP pathway, it's possible for us to hit the script
+ // time limit while holding the durable write lock if a user makes a big
+ // push. Remove the time limit before we acquire the durable lock.
+ set_time_limit(0);
+
$lock_wait = phutil_units('2 minutes in seconds');
try {
$write_wait_start = microtime(true);
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Tue, Nov 26, 7:36 PM (20 h, 55 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6790624
Default Alt Text
D21526.diff (808 B)
Attached To
Mode
D21526: Prevent interruption by the PHP "set_time_limit()" mechanism while holding the durable write lock
Attached
Detach File
Event Timeline
Log In to Comment