Page MenuHomePhabricator

D21440.id51019.diff
No OneTemporary

D21440.id51019.diff

diff --git a/src/view/phui/PHUIObjectItemView.php b/src/view/phui/PHUIObjectItemView.php
--- a/src/view/phui/PHUIObjectItemView.php
+++ b/src/view/phui/PHUIObjectItemView.php
@@ -816,6 +816,23 @@
$box,
));
+ if ($this->menu) {
+ $grid_view = id(new FuelGridView())
+ ->addClass('fuel-grid-tablet');
+ $grid_row = $grid_view->newRow();
+
+ $grid_row->newCell()
+ ->setContent($frame_content);
+
+ $menu = $this->menu;
+
+ $grid_row->newCell()
+ ->addClass('phui-oi-menu')
+ ->setContent($menu);
+
+ $frame_content = $grid_view;
+ }
+
$frame_cover = null;
if ($this->coverImage) {
$cover_image = phutil_tag(
@@ -843,22 +860,7 @@
$frame_content,
));
- $grid_view = id(new FuelGridView())
- ->addClass('fuel-grid-tablet');
- $grid_row = $grid_view->newRow();
-
- $grid_row->newCell()
- ->setContent($frame);
-
- if ($this->menu) {
- $menu = $this->menu;
-
- $grid_row->newCell()
- ->addClass('phui-oi-menu')
- ->setContent($menu);
- }
-
- return $grid_view;
+ return $frame;
}
private function renderStatusIcon($icon, $label) {
diff --git a/webroot/rsrc/css/phui/object-item/phui-oi-list-view.css b/webroot/rsrc/css/phui/object-item/phui-oi-list-view.css
--- a/webroot/rsrc/css/phui/object-item/phui-oi-list-view.css
+++ b/webroot/rsrc/css/phui/object-item/phui-oi-list-view.css
@@ -736,10 +736,9 @@
.device-desktop .phui-oi-menu,
.device-tablet .phui-oi-menu {
width: 200px;
- border-width: 0 0 1px 1px;
+ border-width: 0 0 0 1px;
}
.device-phone .phui-oi-menu {
- border-width: 0 0 1px;
- margin-bottom: 12px;
+ border-width: 1px 0 0;
}

File Metadata

Mime Type
text/plain
Expires
Tue, Nov 26, 6:22 PM (15 h, 59 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6787641
Default Alt Text
D21440.id51019.diff (1 KB)

Event Timeline