Page MenuHomePhabricator
Files F14092455

D18397.diff
No OneTemporary
Actions

D18397.diff
View Options

diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -445,7 +445,6 @@
'DifferentialExactUserFunctionDatasource' => 'applications/differential/typeahead/DifferentialExactUserFunctionDatasource.php',
'DifferentialFieldParseException' => 'applications/differential/exception/DifferentialFieldParseException.php',
'DifferentialFieldValidationException' => 'applications/differential/exception/DifferentialFieldValidationException.php',
- 'DifferentialFindConduitAPIMethod' => 'applications/differential/conduit/DifferentialFindConduitAPIMethod.php',
'DifferentialGetAllDiffsConduitAPIMethod' => 'applications/differential/conduit/DifferentialGetAllDiffsConduitAPIMethod.php',
'DifferentialGetCommitMessageConduitAPIMethod' => 'applications/differential/conduit/DifferentialGetCommitMessageConduitAPIMethod.php',
'DifferentialGetCommitPathsConduitAPIMethod' => 'applications/differential/conduit/DifferentialGetCommitPathsConduitAPIMethod.php',
@@ -5419,7 +5418,6 @@
'DifferentialExactUserFunctionDatasource' => 'PhabricatorTypeaheadCompositeDatasource',
'DifferentialFieldParseException' => 'Exception',
'DifferentialFieldValidationException' => 'Exception',
- 'DifferentialFindConduitAPIMethod' => 'DifferentialConduitAPIMethod',
'DifferentialGetAllDiffsConduitAPIMethod' => 'DifferentialConduitAPIMethod',
'DifferentialGetCommitMessageConduitAPIMethod' => 'DifferentialConduitAPIMethod',
'DifferentialGetCommitPathsConduitAPIMethod' => 'DifferentialConduitAPIMethod',
diff --git a/src/applications/differential/conduit/DifferentialFindConduitAPIMethod.php b/src/applications/differential/conduit/DifferentialFindConduitAPIMethod.php
deleted file mode 100644
--- a/src/applications/differential/conduit/DifferentialFindConduitAPIMethod.php
+++ /dev/null
@@ -1,99 +0,0 @@
-<?php
-
-final class DifferentialFindConduitAPIMethod
- extends DifferentialConduitAPIMethod {
-
- public function getAPIMethodName() {
- return 'differential.find';
- }
-
- public function getMethodStatus() {
- return self::METHOD_STATUS_DEPRECATED;
- }
-
- public function getMethodStatusDescription() {
- return pht("Replaced by '%s'.", 'differential.query');
- }
-
- public function getMethodDescription() {
- return pht('Query Differential revisions which match certain criteria.');
- }
-
- protected function defineParamTypes() {
- $types = array(
- 'open',
- 'committable',
- 'revision-ids',
- 'phids',
- );
-
- return array(
- 'query' => 'required '.$this->formatStringConstants($types),
- 'guids' => 'required nonempty list<guids>',
- );
- }
-
- protected function defineReturnType() {
- return 'nonempty list<dict>';
- }
-
- protected function execute(ConduitAPIRequest $request) {
- $type = $request->getValue('query');
- $guids = $request->getValue('guids');
-
- $results = array();
- if (!$guids) {
- return $results;
- }
-
- $query = id(new DifferentialRevisionQuery())
- ->setViewer($request->getUser());
-
- switch ($type) {
- case 'open':
- $query
- ->withIsOpen(true)
- ->withAuthors($guids);
- break;
- case 'committable':
- $query
- ->withStatuses(DifferentialRevisionStatus::ACCEPTED)
- ->withAuthors($guids);
- break;
- case 'revision-ids':
- $query
- ->withIDs($guids);
- break;
- case 'owned':
- $query->withAuthors($guids);
- break;
- case 'phids':
- $query
- ->withPHIDs($guids);
- break;
- }
-
- $revisions = $query->execute();
-
- foreach ($revisions as $revision) {
- $diff = $revision->loadActiveDiff();
- if (!$diff) {
- continue;
- }
- $id = $revision->getID();
- $results[] = array(
- 'id' => $id,
- 'phid' => $revision->getPHID(),
- 'name' => $revision->getTitle(),
- 'uri' => PhabricatorEnv::getProductionURI('/D'.$id),
- 'dateCreated' => $revision->getDateCreated(),
- 'authorPHID' => $revision->getAuthorPHID(),
- 'statusName' => $revision->getStatusDisplayName(),
- 'sourcePath' => $diff->getSourcePath(),
- );
- }
-
- return $results;
- }
-
-}

File Metadata

Mime Type
text/plain
Expires
Tue, Nov 26, 6:13 AM (20 h, 42 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6788354
Default Alt Text
D18397.diff (4 KB)

Event Timeline

Phabricator · Built by Phacility