Page MenuHomePhabricator

D18916.diff
No OneTemporary

D18916.diff

diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -2094,6 +2094,7 @@
'PhabricatorAuthPasswordEditor' => 'applications/auth/editor/PhabricatorAuthPasswordEditor.php',
'PhabricatorAuthPasswordEngine' => 'applications/auth/engine/PhabricatorAuthPasswordEngine.php',
'PhabricatorAuthPasswordException' => 'applications/auth/password/PhabricatorAuthPasswordException.php',
+ 'PhabricatorAuthPasswordHashInterface' => 'applications/auth/password/PhabricatorAuthPasswordHashInterface.php',
'PhabricatorAuthPasswordPHIDType' => 'applications/auth/phid/PhabricatorAuthPasswordPHIDType.php',
'PhabricatorAuthPasswordQuery' => 'applications/auth/query/PhabricatorAuthPasswordQuery.php',
'PhabricatorAuthPasswordResetTemporaryTokenType' => 'applications/auth/tokentype/PhabricatorAuthPasswordResetTemporaryTokenType.php',
@@ -3496,7 +3497,6 @@
'PhabricatorPassphraseApplication' => 'applications/passphrase/application/PhabricatorPassphraseApplication.php',
'PhabricatorPasswordAuthProvider' => 'applications/auth/provider/PhabricatorPasswordAuthProvider.php',
'PhabricatorPasswordDestructionEngineExtension' => 'applications/auth/extension/PhabricatorPasswordDestructionEngineExtension.php',
- 'PhabricatorPasswordHashInterface' => 'applications/auth/password/PhabricatorPasswordHashInterface.php',
'PhabricatorPasswordHasher' => 'infrastructure/util/password/PhabricatorPasswordHasher.php',
'PhabricatorPasswordHasherTestCase' => 'infrastructure/util/password/__tests__/PhabricatorPasswordHasherTestCase.php',
'PhabricatorPasswordHasherUnavailableException' => 'infrastructure/util/password/PhabricatorPasswordHasherUnavailableException.php',
@@ -9997,7 +9997,7 @@
'PhabricatorFulltextInterface',
'PhabricatorFerretInterface',
'PhabricatorConduitResultInterface',
- 'PhabricatorPasswordHashInterface',
+ 'PhabricatorAuthPasswordHashInterface',
),
'PhabricatorUserBadgesCacheType' => 'PhabricatorUserCacheType',
'PhabricatorUserBlurbField' => 'PhabricatorUserCustomField',
diff --git a/src/applications/auth/engine/PhabricatorAuthPasswordEngine.php b/src/applications/auth/engine/PhabricatorAuthPasswordEngine.php
--- a/src/applications/auth/engine/PhabricatorAuthPasswordEngine.php
+++ b/src/applications/auth/engine/PhabricatorAuthPasswordEngine.php
@@ -27,7 +27,7 @@
return $this->contentSource;
}
- public function setObject(PhabricatorPasswordHashInterface $object) {
+ public function setObject(PhabricatorAuthPasswordHashInterface $object) {
$this->object = $object;
return $this;
}
diff --git a/src/applications/auth/password/PhabricatorPasswordHashInterface.php b/src/applications/auth/password/PhabricatorAuthPasswordHashInterface.php
rename from src/applications/auth/password/PhabricatorPasswordHashInterface.php
rename to src/applications/auth/password/PhabricatorAuthPasswordHashInterface.php
--- a/src/applications/auth/password/PhabricatorPasswordHashInterface.php
+++ b/src/applications/auth/password/PhabricatorAuthPasswordHashInterface.php
@@ -1,6 +1,6 @@
<?php
-interface PhabricatorPasswordHashInterface {
+interface PhabricatorAuthPasswordHashInterface {
public function newPasswordDigest(
PhutilOpaqueEnvelope $envelope,
diff --git a/src/applications/auth/storage/PhabricatorAuthPassword.php b/src/applications/auth/storage/PhabricatorAuthPassword.php
--- a/src/applications/auth/storage/PhabricatorAuthPassword.php
+++ b/src/applications/auth/storage/PhabricatorAuthPassword.php
@@ -21,7 +21,7 @@
const PASSWORD_TYPE_TEST = 'test';
public static function initializeNewPassword(
- PhabricatorPasswordHashInterface $object,
+ PhabricatorAuthPasswordHashInterface $object,
$type) {
return id(new self())
@@ -80,7 +80,7 @@
public function upgradePasswordHasher(
PhutilOpaqueEnvelope $envelope,
- PhabricatorPasswordHashInterface $object) {
+ PhabricatorAuthPasswordHashInterface $object) {
// Before we make changes, double check that this is really the correct
// password. It could be really bad if we "upgraded" a password and changed
@@ -98,7 +98,7 @@
public function setPassword(
PhutilOpaqueEnvelope $password,
- PhabricatorPasswordHashInterface $object) {
+ PhabricatorAuthPasswordHashInterface $object) {
$hasher = PhabricatorPasswordHasher::getBestHasher();
return $this->setPasswordWithHasher($password, $object, $hasher);
@@ -106,7 +106,7 @@
public function setPasswordWithHasher(
PhutilOpaqueEnvelope $password,
- PhabricatorPasswordHashInterface $object,
+ PhabricatorAuthPasswordHashInterface $object,
PhabricatorPasswordHasher $hasher) {
if (!strlen($password->openEnvelope())) {
@@ -130,7 +130,7 @@
public function comparePassword(
PhutilOpaqueEnvelope $password,
- PhabricatorPasswordHashInterface $object) {
+ PhabricatorAuthPasswordHashInterface $object) {
$digest = $this->digestPassword($password, $object);
$hash = $this->newPasswordEnvelope();
@@ -144,7 +144,7 @@
private function digestPassword(
PhutilOpaqueEnvelope $password,
- PhabricatorPasswordHashInterface $object) {
+ PhabricatorAuthPasswordHashInterface $object) {
$object_phid = $object->getPHID();
diff --git a/src/applications/people/storage/PhabricatorUser.php b/src/applications/people/storage/PhabricatorUser.php
--- a/src/applications/people/storage/PhabricatorUser.php
+++ b/src/applications/people/storage/PhabricatorUser.php
@@ -21,7 +21,7 @@
PhabricatorFulltextInterface,
PhabricatorFerretInterface,
PhabricatorConduitResultInterface,
- PhabricatorPasswordHashInterface {
+ PhabricatorAuthPasswordHashInterface {
const SESSION_TABLE = 'phabricator_session';
const NAMETOKEN_TABLE = 'user_nametoken';
@@ -1565,7 +1565,7 @@
return $variables[$variable_key];
}
-/* -( PhabricatorPasswordHashInterface )----------------------------------- */
+/* -( PhabricatorAuthPasswordHashInterface )------------------------------- */
public function newPasswordDigest(

File Metadata

Mime Type
text/plain
Expires
Mon, Nov 25, 11:50 PM (2 h, 13 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6787415
Default Alt Text
D18916.diff (6 KB)

Event Timeline