D6336.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D6336.diff
View Options

	Index: src/workflow/ArcanistCloseRevisionWorkflow.php
	===================================================================
	--- src/workflow/ArcanistCloseRevisionWorkflow.php
	+++ src/workflow/ArcanistCloseRevisionWorkflow.php
	@@ -79,19 +79,17 @@
	$revision_id = reset($revision_list);
	$revision_id = $this->normalizeRevisionID($revision_id);

	- $revision = null;
	- try {
	- $revision = $conduit->callMethodSynchronous(
	- 'differential.getrevision',
	- array(
	- 'revision_id' => $revision_id,
	- ));
	- } catch (Exception $ex) {
	- if (!$is_finalize) {
	- throw new ArcanistUsageException(
	- "Revision D{$revision_id} does not exist."
	- );
	- }
	+ $revisions = $conduit->callMethodSynchronous(
	+ 'differential.query',
	+ array(
	+ 'ids' => array($revision_id),
	+ ));
	+ $revision = head($revisions);
	+
	+ if (!$revision && !$is_finalize) {
	+ throw new ArcanistUsageException(
	+ "Revision D{$revision_id} does not exist."
	+ );
	}

	$status_accepted = ArcanistDifferentialRevisionStatus::ACCEPTED;
	Index: src/workflow/ArcanistTasksWorkflow.php
	===================================================================
	--- src/workflow/ArcanistTasksWorkflow.php
	+++ src/workflow/ArcanistTasksWorkflow.php
	@@ -253,7 +253,7 @@
	$find_params['status'] = ($status ? "status-".$status : "status-open");

	$tasks = $conduit->callMethodSynchronous(
	- 'maniphest.find',
	+ 'maniphest.query',
	$find_params);

	return $tasks;