Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14080939
D20547.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
968 B
Referenced Files
None
Subscribers
None
D20547.diff
View Options
diff --git a/src/applications/herald/controller/HeraldTestConsoleController.php b/src/applications/herald/controller/HeraldTestConsoleController.php
--- a/src/applications/herald/controller/HeraldTestConsoleController.php
+++ b/src/applications/herald/controller/HeraldTestConsoleController.php
@@ -271,6 +271,16 @@
$recent_id = null;
$hard_limit = 1000;
foreach ($xactions as $xaction) {
+
+ // If this transaction has Herald transcript metadata, it was applied by
+ // Herald. Exclude it from the list because the Herald rule engine always
+ // runs before Herald transactions apply, so there's no way that real
+ // rules would have seen this transaction.
+ $transcript_id = $xaction->getMetadataValue('herald:transcriptID');
+ if ($transcript_id !== null) {
+ continue;
+ }
+
$group_id = $xaction->getTransactionGroupID();
// If this is the first transaction, save the group ID: we want to
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Nov 23, 5:31 PM (12 h, 29 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6779058
Default Alt Text
D20547.diff (968 B)
Attached To
Mode
D20547: In the Herald test console, don't consider transactions that Herald rules applied
Attached
Detach File
Event Timeline
Log In to Comment