D10773.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D10773.diff
View Options

	diff --git a/src/lint/engine/ArcanistConfigurationDrivenLintEngine.php b/src/lint/engine/ArcanistConfigurationDrivenLintEngine.php
	--- a/src/lint/engine/ArcanistConfigurationDrivenLintEngine.php
	+++ b/src/lint/engine/ArcanistConfigurationDrivenLintEngine.php
	@@ -129,10 +129,8 @@
	"%s\n",
	pht("Found %d matching paths for linter '%s'.", count($paths), $name));

	- if ($paths) {
	- $linter->setPaths($paths);
	- $built_linters[] = $linter;
	- }
	+ $linter->setPaths($paths);
	+ $built_linters[] = $linter;
	}

	return $built_linters;
	diff --git a/src/lint/linter/ArcanistExternalLinter.php b/src/lint/linter/ArcanistExternalLinter.php
	--- a/src/lint/linter/ArcanistExternalLinter.php
	+++ b/src/lint/linter/ArcanistExternalLinter.php
	@@ -299,6 +299,12 @@
	}

	public function getCacheVersion() {
	+ try {
	+ $this->checkBinaryConfiguration();
	+ } catch (ArcanistMissingLinterException $e) {
	+ return null;
	+ }
	+
	$version = $this->getVersion();

	if ($version) {