Page MenuHomePhabricator

D15019.diff
No OneTemporary

D15019.diff

diff --git a/src/lint/linter/ArcanistCpplintLinter.php b/src/lint/linter/ArcanistCpplintLinter.php
--- a/src/lint/linter/ArcanistCpplintLinter.php
+++ b/src/lint/linter/ArcanistCpplintLinter.php
@@ -19,9 +19,10 @@
public function getInstallInstructions() {
return pht(
- 'Install cpplint.py using `%s`.',
- 'wget http://google-styleguide.googlecode.com'.
- '/svn/trunk/cpplint/cpplint.py');
+ 'Install cpplint.py using `%s`, and place it in your path with the'.
+ 'appropriate permissions set.',
+ 'wget https://raw.github.com'.
+ '/google/styleguide/gh-pages/cpplint/cpplint.py');
}
protected function getDefaultMessageSeverity($code) {
@@ -60,7 +61,7 @@
}
protected function getLintCodeFromLinterConfigurationKey($code) {
- if (!preg_match('@^[a-z_]+/[a-z_]+$@', $code)) {
+ if (!preg_match('@^[a-z_]+/[a-z0-9_+]+$@', $code)) {
throw new Exception(
pht(
'Unrecognized lint message code "%s". Expected a valid cpplint '.

File Metadata

Mime Type
text/plain
Expires
Fri, Nov 22, 10:32 PM (17 h, 8 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6776167
Default Alt Text
D15019.diff (1017 B)

Event Timeline