Page MenuHomePhabricator
Files F14073800

D20800.diff
No OneTemporary
Actions

D20800.diff
View Options

diff --git a/src/applications/phriction/controller/PhrictionDocumentController.php b/src/applications/phriction/controller/PhrictionDocumentController.php
--- a/src/applications/phriction/controller/PhrictionDocumentController.php
+++ b/src/applications/phriction/controller/PhrictionDocumentController.php
@@ -293,37 +293,6 @@
} else {
throw new Exception(pht("Unknown document status '%s'!", $doc_status));
}
-
- $move_notice = null;
- if ($current_status == PhrictionChangeType::CHANGE_MOVE_HERE) {
- $from_doc_id = $content->getChangeRef();
-
- $slug_uri = null;
-
- // If the old document exists and is visible, provide a link to it.
- $from_docs = id(new PhrictionDocumentQuery())
- ->setViewer($viewer)
- ->withIDs(array($from_doc_id))
- ->execute();
- if ($from_docs) {
- $from_doc = head($from_docs);
- $slug_uri = PhrictionDocument::getSlugURI($from_doc->getSlug());
- }
-
- $move_notice = id(new PHUIInfoView())
- ->setSeverity(PHUIInfoView::SEVERITY_NOTICE);
-
- if ($slug_uri) {
- $move_notice->appendChild(
- pht(
- 'This document was moved from %s.',
- phutil_tag('a', array('href' => $slug_uri), $slug_uri)));
- } else {
- // Render this for consistency, even though it's a bit silly.
- $move_notice->appendChild(
- pht('This document was moved from elsewhere.'));
- }
- }
}
$children = $this->renderDocumentChildren($slug);
diff --git a/src/applications/phriction/xaction/PhrictionDocumentMoveToTransaction.php b/src/applications/phriction/xaction/PhrictionDocumentMoveToTransaction.php
--- a/src/applications/phriction/xaction/PhrictionDocumentMoveToTransaction.php
+++ b/src/applications/phriction/xaction/PhrictionDocumentMoveToTransaction.php
@@ -49,7 +49,7 @@
$new = $this->getNewValue();
return pht(
- '%s moved this document from %s',
+ '%s moved this document from %s.',
$this->renderAuthor(),
$this->renderHandle($new['phid']));
}

File Metadata

Mime Type
text/plain
Expires
Fri, Nov 22, 2:31 AM (11 h, 16 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6773264
Default Alt Text
D20800.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility