Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14065838
D13471.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
3 KB
Referenced Files
None
Subscribers
None
D13471.diff
View Options
diff --git a/src/applications/harbormaster/controller/HarbormasterBuildableViewController.php b/src/applications/harbormaster/controller/HarbormasterBuildableViewController.php
--- a/src/applications/harbormaster/controller/HarbormasterBuildableViewController.php
+++ b/src/applications/harbormaster/controller/HarbormasterBuildableViewController.php
@@ -303,7 +303,7 @@
$lint = id(new PHUIObjectBoxView())
->setHeader($lint_header)
- ->appendChild($lint_table);
+ ->setTable($lint_table);
} else {
$lint = null;
}
@@ -327,7 +327,7 @@
$unit = id(new PHUIObjectBoxView())
->setHeader($unit_header)
- ->appendChild($unit_table);
+ ->setTable($unit_table);
} else {
$unit = null;
}
diff --git a/src/applications/harbormaster/controller/HarbormasterUnitMessagesController.php b/src/applications/harbormaster/controller/HarbormasterUnitMessagesController.php
--- a/src/applications/harbormaster/controller/HarbormasterUnitMessagesController.php
+++ b/src/applications/harbormaster/controller/HarbormasterUnitMessagesController.php
@@ -40,7 +40,7 @@
$unit = id(new PHUIObjectBoxView())
->setHeaderText(pht('Unit Tests'))
- ->appendChild($unit_table);
+ ->setTable($unit_table);
$crumbs = $this->buildApplicationCrumbs();
$this->addBuildableCrumb($crumbs, $buildable);
diff --git a/src/applications/owners/controller/PhabricatorOwnersDetailController.php b/src/applications/owners/controller/PhabricatorOwnersDetailController.php
--- a/src/applications/owners/controller/PhabricatorOwnersDetailController.php
+++ b/src/applications/owners/controller/PhabricatorOwnersDetailController.php
@@ -276,7 +276,7 @@
$box = id(new PHUIObjectBoxView())
->setHeaderText(pht('Paths'))
- ->appendChild($table);
+ ->setTable($table);
if ($info) {
$box->setInfoView($info);
diff --git a/src/applications/people/query/PhabricatorPeopleLogSearchEngine.php b/src/applications/people/query/PhabricatorPeopleLogSearchEngine.php
--- a/src/applications/people/query/PhabricatorPeopleLogSearchEngine.php
+++ b/src/applications/people/query/PhabricatorPeopleLogSearchEngine.php
@@ -187,8 +187,7 @@
}
$result = new PhabricatorApplicationSearchResultView();
- $result->setContent($table);
- $result->setCollapsed(true);
+ $result->setTable($table);
return $result;
}
diff --git a/src/applications/repository/query/PhabricatorRepositoryPushLogSearchEngine.php b/src/applications/repository/query/PhabricatorRepositoryPushLogSearchEngine.php
--- a/src/applications/repository/query/PhabricatorRepositoryPushLogSearchEngine.php
+++ b/src/applications/repository/query/PhabricatorRepositoryPushLogSearchEngine.php
@@ -103,13 +103,13 @@
PhabricatorSavedQuery $query,
array $handles) {
- $content = id(new DiffusionPushLogListView())
+ $table = id(new DiffusionPushLogListView())
->setUser($this->requireViewer())
->setHandles($handles)
->setLogs($logs);
return id(new PhabricatorApplicationSearchResultView())
- ->setContent($content);
+ ->setTable($table);
}
}
diff --git a/src/applications/search/view/PhabricatorApplicationSearchResultView.php b/src/applications/search/view/PhabricatorApplicationSearchResultView.php
--- a/src/applications/search/view/PhabricatorApplicationSearchResultView.php
+++ b/src/applications/search/view/PhabricatorApplicationSearchResultView.php
@@ -34,7 +34,7 @@
return $list;
}
- public function setTable(AphrontTableView $table) {
+ public function setTable($table) {
$this->table = $table;
return $this;
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Wed, Nov 20, 6:46 AM (8 m, 21 s)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6753524
Default Alt Text
D13471.diff (3 KB)
Attached To
Mode
D13471: [Redesign] Remove AphrontTable restriction on Search Engine
Attached
Detach File
Event Timeline
Log In to Comment