Page MenuHomePhabricator
Files F14065374

D14746.diff
No OneTemporary
Actions

D14746.diff
View Options

diff --git a/src/applications/maniphest/editor/ManiphestEditEngine.php b/src/applications/maniphest/editor/ManiphestEditEngine.php
--- a/src/applications/maniphest/editor/ManiphestEditEngine.php
+++ b/src/applications/maniphest/editor/ManiphestEditEngine.php
@@ -42,12 +42,11 @@
}
protected function getCommentViewHeaderText($object) {
- $is_serious = PhabricatorEnv::getEnvConfig('phabricator.serious-business');
- if (!$is_serious) {
- return pht('Weigh In');
- }
+ return pht('Weigh In');
+ }
- return parent::getCommentViewHeaderText($object);
+ protected function getCommentViewButtonText($object) {
+ return pht('Set Sail for Adventure');
}
protected function getObjectViewURI($object) {
diff --git a/src/applications/paste/editor/PhabricatorPasteEditEngine.php b/src/applications/paste/editor/PhabricatorPasteEditEngine.php
--- a/src/applications/paste/editor/PhabricatorPasteEditEngine.php
+++ b/src/applications/paste/editor/PhabricatorPasteEditEngine.php
@@ -39,12 +39,11 @@
}
protected function getCommentViewHeaderText($object) {
- $is_serious = PhabricatorEnv::getEnvConfig('phabricator.serious-business');
- if (!$is_serious) {
- return pht('Eat Paste');
- }
+ return pht('Eat Paste');
+ }
- return parent::getCommentViewHeaderText($object);
+ protected function getCommentViewButtonText($object) {
+ return pht('Nom Nom Nom Nom Nom');
}
protected function getObjectViewURI($object) {
diff --git a/src/applications/transactions/editengine/PhabricatorEditEngine.php b/src/applications/transactions/editengine/PhabricatorEditEngine.php
--- a/src/applications/transactions/editengine/PhabricatorEditEngine.php
+++ b/src/applications/transactions/editengine/PhabricatorEditEngine.php
@@ -172,8 +172,24 @@
/**
* @task text
*/
+ protected function getCommentViewSeriousHeaderText($object) {
+ return pht('Take Action');
+ }
+
+
+ /**
+ * @task text
+ */
+ protected function getCommentViewSeriousButtonText($object) {
+ return pht('Submit');
+ }
+
+
+ /**
+ * @task text
+ */
protected function getCommentViewHeaderText($object) {
- return pht('Add Comment');
+ return $this->getCommentViewSeriousHeaderText($object);
}
@@ -181,7 +197,7 @@
* @task text
*/
protected function getCommentViewButtonText($object) {
- return pht('Add Comment');
+ return $this->getCommentViewSeriousButtonText($object);
}
@@ -1125,8 +1141,15 @@
$viewer = $this->getViewer();
$object_phid = $object->getPHID();
- $header_text = $this->getCommentViewHeaderText($object);
- $button_text = $this->getCommentViewButtonText($object);
+ $is_serious = PhabricatorEnv::getEnvConfig('phabricator.serious-business');
+
+ if ($is_serious) {
+ $header_text = $this->getCommentViewSeriousHeaderText($object);
+ $button_text = $this->getCommentViewSeriousButtonText($object);
+ } else {
+ $header_text = $this->getCommentViewHeaderText($object);
+ $button_text = $this->getCommentViewButtonText($object);
+ }
$comment_uri = $this->getEditURI($object, 'comment/');

File Metadata

Mime Type
text/plain
Expires
Wed, Nov 20, 4:25 AM (16 h, 6 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6732251
Default Alt Text
D14746.diff (3 KB)

Event Timeline

Phabricator · Built by Phacility