Page MenuHomePhabricator
Files F14064635

D17081.diff
No OneTemporary
Actions

D17081.diff
View Options

diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -565,7 +565,6 @@
'DifferentialSetDiffPropertyConduitAPIMethod' => 'applications/differential/conduit/DifferentialSetDiffPropertyConduitAPIMethod.php',
'DifferentialStoredCustomField' => 'applications/differential/customfield/DifferentialStoredCustomField.php',
'DifferentialSubscribersCommitMessageField' => 'applications/differential/field/DifferentialSubscribersCommitMessageField.php',
- 'DifferentialSubscribersField' => 'applications/differential/customfield/DifferentialSubscribersField.php',
'DifferentialSummaryCommitMessageField' => 'applications/differential/field/DifferentialSummaryCommitMessageField.php',
'DifferentialSummaryField' => 'applications/differential/customfield/DifferentialSummaryField.php',
'DifferentialTagsCommitMessageField' => 'applications/differential/field/DifferentialTagsCommitMessageField.php',
@@ -5231,7 +5230,6 @@
'DifferentialSetDiffPropertyConduitAPIMethod' => 'DifferentialConduitAPIMethod',
'DifferentialStoredCustomField' => 'DifferentialCustomField',
'DifferentialSubscribersCommitMessageField' => 'DifferentialCommitMessageField',
- 'DifferentialSubscribersField' => 'DifferentialCoreCustomField',
'DifferentialSummaryCommitMessageField' => 'DifferentialCommitMessageField',
'DifferentialSummaryField' => 'DifferentialCoreCustomField',
'DifferentialTagsCommitMessageField' => 'DifferentialCommitMessageField',
diff --git a/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php b/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php
--- a/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php
+++ b/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php
@@ -30,7 +30,6 @@
new DifferentialTestPlanField(),
new DifferentialReviewersField(),
new DifferentialProjectReviewersField(),
- new DifferentialSubscribersField(),
new DifferentialRepositoryField(),
new DifferentialViewPolicyField(),
diff --git a/src/applications/differential/customfield/DifferentialSubscribersField.php b/src/applications/differential/customfield/DifferentialSubscribersField.php
deleted file mode 100644
--- a/src/applications/differential/customfield/DifferentialSubscribersField.php
+++ /dev/null
@@ -1,93 +0,0 @@
-<?php
-
-final class DifferentialSubscribersField
- extends DifferentialCoreCustomField {
-
- public function getFieldKey() {
- return 'differential:subscribers';
- }
-
- public function getFieldKeyForConduit() {
- return 'ccPHIDs';
- }
-
- public function getFieldName() {
- return pht('Subscribers');
- }
-
- public function getFieldDescription() {
- return pht('Manage subscribers.');
- }
-
- protected function readValueFromRevision(
- DifferentialRevision $revision) {
- if (!$revision->getPHID()) {
- return array();
- }
-
- return PhabricatorSubscribersQuery::loadSubscribersForPHID(
- $revision->getPHID());
- }
-
- public function getNewValueForApplicationTransactions() {
- return array('=' => $this->getValue());
- }
-
- public function readValueFromRequest(AphrontRequest $request) {
- $this->setValue($request->getArr($this->getFieldKey()));
- }
-
- public function renderEditControl(array $handles) {
- return id(new AphrontFormTokenizerControl())
- ->setUser($this->getViewer())
- ->setName($this->getFieldKey())
- ->setDatasource(new PhabricatorMetaMTAMailableDatasource())
- ->setValue($this->getValue())
- ->setError($this->getFieldError())
- ->setLabel($this->getFieldName());
- }
-
- public function getApplicationTransactionType() {
- return PhabricatorTransactions::TYPE_SUBSCRIBERS;
- }
-
- public function shouldAppearInCommitMessage() {
- return true;
- }
-
- public function shouldAllowEditInCommitMessage() {
- return true;
- }
-
- public function shouldAppearInCommitMessageTemplate() {
- return true;
- }
-
- public function getCommitMessageLabels() {
- return array(
- 'CC',
- 'CCs',
- 'Subscriber',
- 'Subscribers',
- );
- }
-
- public function parseValueFromCommitMessage($value) {
- return $this->parseObjectList(
- $value,
- array(
- PhabricatorPeopleUserPHIDType::TYPECONST,
- PhabricatorProjectProjectPHIDType::TYPECONST,
- PhabricatorOwnersPackagePHIDType::TYPECONST,
- ));
- }
-
- public function getRequiredHandlePHIDsForCommitMessage() {
- return $this->getValue();
- }
-
- public function renderCommitMessageValue(array $handles) {
- return $this->renderObjectList($handles);
- }
-
-}

File Metadata

Mime Type
text/plain
Expires
Wed, Nov 20, 12:34 AM (19 h, 19 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6733822
Default Alt Text
D17081.diff (4 KB)

Event Timeline

Phabricator · Built by Phacility