Page MenuHomePhabricator

D13520.diff
No OneTemporary

D13520.diff

diff --git a/src/applications/phame/controller/PhameController.php b/src/applications/phame/controller/PhameController.php
--- a/src/applications/phame/controller/PhameController.php
+++ b/src/applications/phame/controller/PhameController.php
@@ -107,9 +107,9 @@
}
if (empty($stories)) {
- return id(new PHUIInfoView())
- ->setSeverity(PHUIInfoView::SEVERITY_NODATA)
- ->appendChild($nodata);
+ return id(new PHUIBoxView())
+ ->appendChild($nodata)
+ ->addClass('mlt mlb msr msl');
}
return $stories;
diff --git a/src/applications/phame/controller/blog/PhameBlogListController.php b/src/applications/phame/controller/blog/PhameBlogListController.php
--- a/src/applications/phame/controller/blog/PhameBlogListController.php
+++ b/src/applications/phame/controller/blog/PhameBlogListController.php
@@ -38,13 +38,17 @@
$blog_list = $this->renderBlogList($blogs, $user, $nodata);
$blog_list->setPager($pager);
+ $box = id (new PHUIObjectBoxView())
+ ->setHeaderText($title)
+ ->setObjectList($blog_list);
+
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addTextCrumb($title, $this->getApplicationURI());
$nav->appendChild(
array(
$crumbs,
- $blog_list,
+ $box,
));
return $this->buildApplicationPage(
diff --git a/src/applications/phame/controller/post/PhamePostListController.php b/src/applications/phame/controller/post/PhamePostListController.php
--- a/src/applications/phame/controller/post/PhamePostListController.php
+++ b/src/applications/phame/controller/post/PhamePostListController.php
@@ -18,6 +18,7 @@
->setViewer($user);
$nav = $this->renderSideNavFilterView();
+ $nodata = null;
switch ($this->filter) {
case 'draft':
@@ -46,7 +47,7 @@
} else {
$nodata = pht('%s has not written any posts.', $blogger);
}
- $title = pht('Posts By %s', $blogger);
+ $title = pht('Posts by %s', $blogger);
break;
case 'all':
$nodata = pht('There are no visible posts.');
@@ -64,13 +65,11 @@
require_celerity_resource('phame-css');
$post_list = $this->renderPostList($posts, $user, $nodata);
- $post_list = id(new PHUIBoxView())
- ->addPadding(PHUI::PADDING_LARGE)
- ->addClass('phame-post-list')
+ $post_list = id(new PHUIObjectBoxView())
+ ->setHeaderText($title)
->appendChild($post_list);
$crumbs = $this->buildApplicationCrumbs();
- $crumbs->setBorder(true);
$crumbs->addTextCrumb($title, $this->getApplicationURI());
$nav->appendChild(

File Metadata

Mime Type
text/plain
Expires
Mon, Nov 18, 3:00 PM (1 d, 18 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6736073
Default Alt Text
D13520.diff (2 KB)

Event Timeline