Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14054509
D15557.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
2 KB
Referenced Files
None
Subscribers
None
D15557.diff
View Options
diff --git a/src/applications/slowvote/controller/PhabricatorSlowvoteEditController.php b/src/applications/slowvote/controller/PhabricatorSlowvoteEditController.php
--- a/src/applications/slowvote/controller/PhabricatorSlowvoteEditController.php
+++ b/src/applications/slowvote/controller/PhabricatorSlowvoteEditController.php
@@ -136,21 +136,10 @@
}
}
- $instructions =
- phutil_tag(
- 'p',
- array(
- 'class' => 'aphront-form-instructions',
- ),
- pht('Resolve issues and build consensus through '.
- 'protracted deliberation.'));
-
$form = id(new AphrontFormView())
->setUser($viewer)
- ->appendChild($instructions)
->appendChild(
- id(new AphrontFormTextAreaControl())
- ->setHeight(AphrontFormTextAreaControl::HEIGHT_VERY_SHORT)
+ id(new AphrontFormTextControl())
->setLabel(pht('Question'))
->setName('question')
->setValue($v_question)
@@ -218,10 +207,12 @@
$title = pht('Create Slowvote');
$button = pht('Create');
$cancel_uri = $this->getApplicationURI();
+ $header_icon = 'fa-plus-square';
} else {
- $title = pht('Edit %s', 'V'.$poll->getID());
+ $title = pht('Edit Poll: %s', $poll->getQuestion());
$button = pht('Save Changes');
$cancel_uri = '/V'.$poll->getID();
+ $header_icon = 'fa-pencil';
}
$policies = id(new PhabricatorPolicyQuery())
@@ -259,18 +250,28 @@
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addTextCrumb($title);
+ $crumbs->setBorder(true);
$form_box = id(new PHUIObjectBoxView())
- ->setHeaderText($title)
+ ->setHeaderText(pht('Poll'))
->setFormErrors($errors)
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setForm($form);
+ $header = id(new PHUIHeaderView())
+ ->setHeader($title)
+ ->setHeaderIcon($header_icon);
+
+ $view = id(new PHUITwoColumnView())
+ ->setHeader($header)
+ ->setFooter($form_box);
+
return $this->newPage()
->setTitle($title)
->setCrumbs($crumbs)
->appendChild(
array(
- $form_box,
+ $view,
));
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Nov 17, 2:38 AM (2 d, 22 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6735391
Default Alt Text
D15557.diff (2 KB)
Attached To
Mode
D15557: Convert Slowvote Edit page to new UI
Attached
Detach File
Event Timeline
Log In to Comment