Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14053875
D14386.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
889 B
Referenced Files
None
Subscribers
None
D14386.diff
View Options
diff --git a/src/applications/phurl/controller/PhabricatorPhurlURLViewController.php b/src/applications/phurl/controller/PhabricatorPhurlURLViewController.php
--- a/src/applications/phurl/controller/PhabricatorPhurlURLViewController.php
+++ b/src/applications/phurl/controller/PhabricatorPhurlURLViewController.php
@@ -35,9 +35,13 @@
$properties = $this->buildPropertyView($url);
$properties->setActionList($actions);
+ $url_error = id(new PHUIInfoView())
+ ->setErrors(array(pht('This URL is invalid due to a bad protocol.')))
+ ->setIsHidden($url->isValid());
$box = id(new PHUIObjectBoxView())
->setHeader($header)
- ->addPropertyList($properties);
+ ->addPropertyList($properties)
+ ->setInfoView($url_error);
$is_serious = PhabricatorEnv::getEnvConfig('phabricator.serious-business');
$add_comment_header = $is_serious
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Nov 16, 8:08 PM (2 d, 16 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6713852
Default Alt Text
D14386.diff (889 B)
Attached To
Mode
D14386: Phurl URL object should show a banner if the URL is invalid
Attached
Detach File
Event Timeline
Log In to Comment