Page MenuHomePhabricator

D19416.diff
No OneTemporary

D19416.diff

diff --git a/src/applications/differential/controller/DifferentialRevisionViewController.php b/src/applications/differential/controller/DifferentialRevisionViewController.php
--- a/src/applications/differential/controller/DifferentialRevisionViewController.php
+++ b/src/applications/differential/controller/DifferentialRevisionViewController.php
@@ -153,9 +153,17 @@
$request_uri = $request->getRequestURI();
+ // Revisions with more than 100 files are "large".
+ // Revisions with more than 1000 files are "very large".
$limit = 100;
$large = $request->getStr('large');
- if (count($changesets) > $limit && !$large) {
+
+ $large_warning =
+ (!$this->isVeryLargeDiff()) &&
+ (count($changesets) > $limit) &&
+ (!$large);
+
+ if ($large_warning) {
$count = count($changesets);
$warning = new PHUIInfoView();
$warning->setTitle(pht('Large Diff'));

File Metadata

Mime Type
text/plain
Expires
Fri, Nov 15, 5:37 AM (2 d, 9 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6757217
Default Alt Text
D19416.diff (918 B)

Event Timeline