Page MenuHomePhabricator
Files F14046181

D11932.id28740.diff
No OneTemporary
Actions

D11932.id28740.diff
View Options

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -7,7 +7,7 @@
*/
return array(
'names' => array(
- 'core.pkg.css' => 'cb58febe',
+ 'core.pkg.css' => 'cd54f10c',
'core.pkg.js' => '23d653bb',
'darkconsole.pkg.js' => '8ab24e01',
'differential.pkg.css' => '4c3242f8',
@@ -135,7 +135,7 @@
'rsrc/css/phui/phui-icon.css' => 'd35aa857',
'rsrc/css/phui/phui-image-mask.css' => '5a8b09c8',
'rsrc/css/phui/phui-info-panel.css' => '27ea50a1',
- 'rsrc/css/phui/phui-info-view.css' => '0c8e5d50',
+ 'rsrc/css/phui/phui-info-view.css' => '6c6cc4dd',
'rsrc/css/phui/phui-list.css' => '53deb25c',
'rsrc/css/phui/phui-object-box.css' => 'd68ce5dc',
'rsrc/css/phui/phui-object-item-list-view.css' => '9db65899',
@@ -789,7 +789,7 @@
'phui-icon-view-css' => 'd35aa857',
'phui-image-mask-css' => '5a8b09c8',
'phui-info-panel-css' => '27ea50a1',
- 'phui-info-view-css' => '0c8e5d50',
+ 'phui-info-view-css' => '6c6cc4dd',
'phui-list-view-css' => '53deb25c',
'phui-object-box-css' => 'd68ce5dc',
'phui-object-item-list-view-css' => '9db65899',
diff --git a/src/applications/maniphest/controller/ManiphestTaskDetailController.php b/src/applications/maniphest/controller/ManiphestTaskDetailController.php
--- a/src/applications/maniphest/controller/ManiphestTaskDetailController.php
+++ b/src/applications/maniphest/controller/ManiphestTaskDetailController.php
@@ -94,6 +94,7 @@
$info_view->setSeverity(PHUIInfoView::SEVERITY_NOTICE);
$info_view->addButton(
id(new PHUIButtonView())
+ ->setTag('a')
->setHref('/maniphest/task/create/?parent='.$parent_task->getID())
->setText(pht('Create Another Subtask')));
@@ -105,10 +106,12 @@
$info_view->setSeverity(PHUIInfoView::SEVERITY_NOTICE);
$info_view->addButton(
id(new PHUIButtonView())
+ ->setTag('a')
->setHref('/maniphest/task/create/?template='.$task->getID())
->setText(pht('Similar Task')));
$info_view->addButton(
id(new PHUIButtonView())
+ ->setTag('a')
->setHref('/maniphest/task/create/')
->setText(pht('Empty Task')));
$info_view->appendChild(pht('New task created. Create another?'));
diff --git a/src/applications/uiexample/examples/PHUIInfoExample.php b/src/applications/uiexample/examples/PHUIInfoExample.php
--- a/src/applications/uiexample/examples/PHUIInfoExample.php
+++ b/src/applications/uiexample/examples/PHUIInfoExample.php
@@ -26,7 +26,7 @@
$button = id(new PHUIButtonView())
->setTag('a')
->setText('Resolve Issue')
- ->addClass('grey');
+ ->setHref('#');
$views = array();
// Only Title
diff --git a/src/view/form/PHUIInfoView.php b/src/view/form/PHUIInfoView.php
--- a/src/view/form/PHUIInfoView.php
+++ b/src/view/form/PHUIInfoView.php
@@ -34,7 +34,8 @@
return $this;
}
- public function addButton($button) {
+ public function addButton(PHUIButtonView $button) {
+
$this->buttons[] = $button;
return $this;
}
diff --git a/webroot/rsrc/css/phui/phui-info-view.css b/webroot/rsrc/css/phui/phui-info-view.css
--- a/webroot/rsrc/css/phui/phui-info-view.css
+++ b/webroot/rsrc/css/phui/phui-info-view.css
@@ -60,52 +60,52 @@
}
.phui-info-severity-error,
-.phui-info-severity-error .button {
+.phui-info-severity-error a.button {
border-color: {$red};
background: {$lightred};
}
-.phui-info-severity-error .button {
+.phui-info-severity-error a.button {
color: {$red};
}
.phui-info-severity-warning,
-.phui-info-severity-warning .button {
+.phui-info-severity-warning a.button {
border-color: {$yellow};
background: {$lightyellow};
}
-.phui-info-severity-warning .button {
+.phui-info-severity-warning a.button {
color: #bc7837;
}
.phui-info-severity-notice,
-.phui-info-severity-notice .button {
+.phui-info-severity-notice a.button {
border-color: {$blue};
background: {$lightblue};
}
-.phui-info-severity-notice .button {
+.phui-info-severity-notice a.button {
color: {$blue};
}
.phui-info-severity-nodata,
-.phui-info-severity-nodata .button {
+.phui-info-severity-nodata a.button {
border-color: {$lightgreyborder};
background: #fff;
}
-.phui-info-severity-nodata .button {
+.phui-info-severity-nodata a.button {
color: {$greytext};
}
.phui-info-severity-success,
-.phui-info-severity-success .button {
+.phui-info-severity-success a.button {
border-color: {$green};
background: {$lightgreen};
}
-.phui-info-severity-success .button {
+.phui-info-severity-success a.button {
color: {$green};
}

File Metadata

Mime Type
text/plain
Expires
Thu, Nov 14, 7:08 PM (1 d, 9 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6716785
Default Alt Text
D11932.id28740.diff (4 KB)

Event Timeline

Phabricator · Built by Phacility