Page MenuHomePhabricator

D16736.diff
No OneTemporary

D16736.diff

diff --git a/src/applications/search/controller/PhabricatorApplicationSearchController.php b/src/applications/search/controller/PhabricatorApplicationSearchController.php
--- a/src/applications/search/controller/PhabricatorApplicationSearchController.php
+++ b/src/applications/search/controller/PhabricatorApplicationSearchController.php
@@ -111,6 +111,7 @@
'before' => true,
'after' => true,
'nux' => true,
+ 'overheated' => true,
);
foreach ($pt_data as $pt_key => $pt_value) {
@@ -238,7 +239,8 @@
$nux_view = null;
}
- $is_overheated = $query->getIsOverheated();
+ $force_overheated = $request->getBool('overheated');
+ $is_overheated = $query->getIsOverheated() || $force_overheated;
if ($nux_view) {
$box->appendChild($nux_view);
@@ -277,13 +279,23 @@
$header = $result_header;
}
- if ($list->getActions()) {
- foreach ($list->getActions() as $action) {
+ $actions = $list->getActions();
+ if ($actions) {
+ foreach ($actions as $action) {
$header->addActionLink($action);
}
}
$use_actions = $engine->newUseResultsActions($saved_query);
+
+ // TODO: Eventually, modularize all this stuff.
+ $builtin_use_actions = $this->newBuiltinUseActions();
+ if ($builtin_use_actions) {
+ foreach ($builtin_use_actions as $builtin_use_action) {
+ $use_actions[] = $builtin_use_action;
+ }
+ }
+
if ($use_actions) {
$use_dropdown = $this->newUseResultsDropdown(
$saved_query,
@@ -554,4 +566,34 @@
));
}
+ private function newBuiltinUseActions() {
+ $actions = array();
+
+ $is_dev = PhabricatorEnv::getEnvConfig('phabricator.developer-mode');
+
+ if ($is_dev) {
+ $engine = $this->getSearchEngine();
+ $nux_uri = $engine->getQueryBaseURI();
+ $nux_uri = id(new PhutilURI($nux_uri))
+ ->setQueryParam('nux', true);
+
+ $actions[] = id(new PhabricatorActionView())
+ ->setIcon('fa-bug')
+ ->setName(pht('Developer: Show New User State'))
+ ->setHref($nux_uri);
+ }
+
+ if ($is_dev) {
+ $overheated_uri = $this->getRequest()->getRequestURI()
+ ->setQueryParam('overheated', true);
+
+ $actions[] = id(new PhabricatorActionView())
+ ->setIcon('fa-bug')
+ ->setName(pht('Developer: Show Overheated State'))
+ ->setHref($overheated_uri);
+ }
+
+ return $actions;
+ }
+
}
diff --git a/src/applications/search/engine/PhabricatorApplicationSearchEngine.php b/src/applications/search/engine/PhabricatorApplicationSearchEngine.php
--- a/src/applications/search/engine/PhabricatorApplicationSearchEngine.php
+++ b/src/applications/search/engine/PhabricatorApplicationSearchEngine.php
@@ -406,6 +406,10 @@
return $this->getURI('query/edit/');
}
+ public function getQueryBaseURI() {
+ return $this->getURI('');
+ }
+
/**
* Return the URI to a path within the application. Used to construct default

File Metadata

Mime Type
text/plain
Expires
Wed, Nov 13, 11:10 AM (5 d, 1 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6747853
Default Alt Text
D16736.diff (3 KB)

Event Timeline