D13800.id33328.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D13800.id33328.diff
View Options

	diff --git a/src/applications/transactions/storage/PhabricatorApplicationTransaction.php b/src/applications/transactions/storage/PhabricatorApplicationTransaction.php
	--- a/src/applications/transactions/storage/PhabricatorApplicationTransaction.php
	+++ b/src/applications/transactions/storage/PhabricatorApplicationTransaction.php
	@@ -362,11 +362,23 @@
	case PhabricatorTransactions::TYPE_COMMENT:
	$comment = $this->getComment();
	if ($comment && $comment->getIsRemoved()) {
	- return 'fa-eraser';
	+ return 'fa-trash';
	}
	return 'fa-comment';
	case PhabricatorTransactions::TYPE_SUBSCRIBERS:
	- return 'fa-envelope';
	+ $old = $this->getOldValue();
	+ $new = $this->getNewValue();
	+ $add = array_diff($new, $old);
	+ $rem = array_diff($old, $new);
	+ if ($add && $rem) {
	+ return 'fa-user';
	+ } else if ($add) {
	+ return 'fa-user-plus';
	+ } else if ($rem) {
	+ return 'fa-user-times';
	+ } else {
	+ return 'fa-user';
	+ }
	case PhabricatorTransactions::TYPE_VIEW_POLICY:
	case PhabricatorTransactions::TYPE_EDIT_POLICY:
	case PhabricatorTransactions::TYPE_JOIN_POLICY:
	@@ -416,6 +428,21 @@
	return 'red';
	}
	break;
	+ case PhabricatorTransactions::TYPE_SUBSCRIBERS:
	+ $old = $this->getOldValue();
	+ $new = $this->getNewValue();
	+ $add = array_diff($new, $old);
	+ $rem = array_diff($old, $new);
	+ if ($add && $rem) {
	+ return 'green';
	+ } else if ($add) {
	+ return 'green';
	+ } else if ($rem) {
	+ return 'black';
	+ } else {
	+ return null;
	+ }
	+ break;
	}
	return null;
	}