Page MenuHomePhabricator
Files F14039111

D8639.diff
No OneTemporary
Actions

D8639.diff
View Options

diff --git a/src/applications/maniphest/storage/ManiphestTransaction.php b/src/applications/maniphest/storage/ManiphestTransaction.php
--- a/src/applications/maniphest/storage/ManiphestTransaction.php
+++ b/src/applications/maniphest/storage/ManiphestTransaction.php
@@ -92,9 +92,9 @@
public function shouldHide() {
switch ($this->getTransactionType()) {
- case self::TYPE_TITLE:
case self::TYPE_DESCRIPTION:
case self::TYPE_PRIORITY:
+ case self::TYPE_STATUS:
if ($this->getOldValue() === null) {
return true;
} else {
@@ -110,6 +110,8 @@
public function getActionStrength() {
switch ($this->getTransactionType()) {
+ case self::TYPE_TITLE:
+ return 1.4;
case self::TYPE_STATUS:
return 1.3;
case self::TYPE_OWNER:
@@ -170,13 +172,13 @@
switch ($this->getTransactionType()) {
case self::TYPE_TITLE:
- return pht('Retitled');
-
- case self::TYPE_STATUS:
if ($old === null) {
return pht('Created');
}
+ return pht('Retitled');
+
+ case self::TYPE_STATUS:
$action = ManiphestTaskStatus::getStatusActionName($new);
if ($action) {
return $action;
@@ -245,13 +247,13 @@
return 'meta-mta';
case self::TYPE_TITLE:
- return 'edit';
-
- case self::TYPE_STATUS:
if ($old === null) {
return 'create';
}
+ return 'edit';
+
+ case self::TYPE_STATUS:
$action = ManiphestTaskStatus::getStatusIcon($new);
if ($action !== null) {
return $action;
@@ -301,6 +303,11 @@
switch ($this->getTransactionType()) {
case self::TYPE_TITLE:
+ if ($old === null) {
+ return pht(
+ '%s created this task.',
+ $this->renderHandleLink($author_phid));
+ }
return pht(
'%s changed the title from "%s" to "%s".',
$this->renderHandleLink($author_phid),
@@ -313,12 +320,6 @@
$this->renderHandleLink($author_phid));
case self::TYPE_STATUS:
- if ($old === null) {
- return pht(
- '%s created this task.',
- $this->renderHandleLink($author_phid));
- }
-
$old_closed = ManiphestTaskStatus::isClosedStatus($old);
$new_closed = ManiphestTaskStatus::isClosedStatus($new);
@@ -493,6 +494,13 @@
switch ($this->getTransactionType()) {
case self::TYPE_TITLE:
+ if ($old === null) {
+ return pht(
+ '%s created %s.',
+ $this->renderHandleLink($author_phid),
+ $this->renderHandleLink($object_phid));
+ }
+
return pht(
'%s renamed %s from "%s" to "%s".',
$this->renderHandleLink($author_phid),
@@ -507,13 +515,6 @@
$this->renderHandleLink($object_phid));
case self::TYPE_STATUS:
- if ($old === null) {
- return pht(
- '%s created %s.',
- $this->renderHandleLink($author_phid),
- $this->renderHandleLink($object_phid));
- }
-
$old_closed = ManiphestTaskStatus::isClosedStatus($old);
$new_closed = ManiphestTaskStatus::isClosedStatus($new);

File Metadata

Mime Type
text/plain
Expires
Tue, Nov 12, 3:49 AM (4 d, 18 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6731198
Default Alt Text
D8639.diff (3 KB)

Event Timeline

Phabricator · Built by Phacility