Page MenuHomePhabricator

D14815.diff
No OneTemporary

D14815.diff

diff --git a/src/applications/transactions/editengine/PhabricatorEditEngine.php b/src/applications/transactions/editengine/PhabricatorEditEngine.php
--- a/src/applications/transactions/editengine/PhabricatorEditEngine.php
+++ b/src/applications/transactions/editengine/PhabricatorEditEngine.php
@@ -1741,7 +1741,8 @@
->setName($group_name);
foreach ($configs as $config) {
- $items[] = $this->newQuickCreateItem($config);
+ $items[] = $this->newQuickCreateItem($config)
+ ->setIndented(true);
}
}
diff --git a/src/view/phui/PHUIListItemView.php b/src/view/phui/PHUIListItemView.php
--- a/src/view/phui/PHUIListItemView.php
+++ b/src/view/phui/PHUIListItemView.php
@@ -28,6 +28,7 @@
private $order;
private $aural;
private $profileImage;
+ private $indented;
public function setDropdownMenu(PhabricatorActionListView $actions) {
Javelin::initBehavior('phui-dropdown-menu');
@@ -91,6 +92,15 @@
return $this->icon;
}
+ public function setIndented($indented) {
+ $this->indented = $indented;
+ return $this;
+ }
+
+ public function getIndented() {
+ return $this->indented;
+ }
+
public function setKey($key) {
$this->key = (string)$key;
return $this;
@@ -256,11 +266,20 @@
->setIconFont($this->appIcon);
}
+ $classes = array();
+ if ($this->href) {
+ $classes[] = 'phui-list-item-href';
+ }
+
+ if ($this->indented) {
+ $classes[] = 'phui-list-item-indented';
+ }
+
return javelin_tag(
$this->href ? 'a' : 'div',
array(
'href' => $this->href,
- 'class' => $this->href ? 'phui-list-item-href' : null,
+ 'class' => implode(' ', $classes),
'meta' => $meta,
'sigil' => $sigil,
),
diff --git a/webroot/rsrc/css/phui/phui-list.css b/webroot/rsrc/css/phui/phui-list.css
--- a/webroot/rsrc/css/phui/phui-list.css
+++ b/webroot/rsrc/css/phui/phui-list.css
@@ -70,6 +70,11 @@
padding: 4px 10px;
}
+.phui-list-sidenav .phui-list-item-has-icon .phui-list-item-indented {
+ padding-left: 18px;
+}
+
+
.device-desktop .phui-list-sidenav .phui-list-item-href:hover {
background: {$sky};
color: white;

File Metadata

Mime Type
text/plain
Expires
Tue, Nov 12, 3:17 AM (1 w, 5 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6711405
Default Alt Text
D14815.diff (2 KB)

Event Timeline