Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14038845
D9734.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
2 KB
Referenced Files
None
Subscribers
None
D9734.diff
View Options
diff --git a/src/applications/legalpad/controller/LegalpadDocumentSignController.php b/src/applications/legalpad/controller/LegalpadDocumentSignController.php
--- a/src/applications/legalpad/controller/LegalpadDocumentSignController.php
+++ b/src/applications/legalpad/controller/LegalpadDocumentSignController.php
@@ -193,19 +193,25 @@
->setDisabled(!$can_edit)
->setWorkflow(!$can_edit));
- $content = array(
- $this->buildDocument(
- $header,
- $engine,
- $document_body),
- $this->buildSignatureForm(
- $document_body,
- $signature,
- $has_signed,
- $e_name,
- $e_email,
- $e_address_1,
- $error_view));
+ $signature_form = $this->buildSignatureForm(
+ $document_body,
+ $signature,
+ $has_signed,
+ $e_name,
+ $e_email,
+ $e_address_1);
+
+ $content = $this->buildDocument(
+ $header,
+ $engine,
+ $document_body);
+
+ $content->appendChild(
+ array(
+ id(new PHUIHeaderView())->setHeader(pht('Agree and Sign Document')),
+ $error_view,
+ $signature_form,
+ ));
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addTextCrumb($document->getMonogram());
@@ -240,8 +246,7 @@
$has_signed = false,
$e_name = true,
$e_email = true,
- $e_address_1 = true,
- $error_view = null) {
+ $e_address_1 = true) {
$viewer = $this->getRequest()->getUser();
if ($has_signed) {
@@ -297,16 +302,10 @@
->appendChild(
id(new AphrontFormSubmitControl())
->setValue(pht('Sign and Agree'))
- ->setDisabled($has_signed));
-
- $view = id(new PHUIObjectBoxView())
- ->setHeaderText(pht('Sign and Agree'))
- ->setForm($form);
- if ($error_view) {
- $view->setErrorView($error_view);
- }
+ ->setDisabled($has_signed)
+ ->addCancelButton($this->getApplicationURI()));
- return $view;
+ return $form;
}
private function getVerifiedSignatureBlurb() {
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Tue, Nov 12, 2:26 AM (2 d, 1 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6712609
Default Alt Text
D9734.diff (2 KB)
Attached To
Mode
D9734: Move Legalpad signature form inline in document
Attached
Detach File
Event Timeline
Log In to Comment