Page MenuHomePhabricator
Files F14037870

D13277.diff
No OneTemporary
Actions

D13277.diff
View Options

diff --git a/src/docs/contributor/css_coding_standards.diviner b/src/docs/contributor/css_coding_standards.diviner
--- a/src/docs/contributor/css_coding_standards.diviner
+++ b/src/docs/contributor/css_coding_standards.diviner
@@ -22,6 +22,7 @@
Phabricator's preprocessor provides some standard color variables. You can
reference these with `{$color}`. For example:
+ lang=css
span.critical {
color: {$red};
}
@@ -78,6 +79,7 @@
Since many rules are specific to handheld devices, the `.device` class selects
either tablets or phones:
+ lang=css
.device {
/* Phone or tablet (not desktop). */
}
diff --git a/src/docs/contributor/php_coding_standards.diviner b/src/docs/contributor/php_coding_standards.diviner
--- a/src/docs/contributor/php_coding_standards.diviner
+++ b/src/docs/contributor/php_coding_standards.diviner
@@ -67,6 +67,7 @@
**if/else:**
+ lang=php
if ($some_variable > 3) {
// ...
} else if ($some_variable === null) {
@@ -81,6 +82,7 @@
**for:**
+ lang=php
for ($ii = 0; $ii < 10; $ii++) {
// ...
}
@@ -90,12 +92,14 @@
**foreach:**
+ lang=php
foreach ($map as $key => $value) {
// ...
}
**switch:**
+ lang=php
switch ($value) {
case 1:
// ...
@@ -115,6 +119,7 @@
**array literals:**
+ lang=php
$junk = array(
'nuts',
'bolts',
@@ -126,6 +131,7 @@
**operators:**
+ lang=php
$a + $b; // Put spaces around operators.
$omg.$lol; // Exception: no spaces around string concatenation.
$arr[] = $element; // Couple [] with the array when appending.
@@ -133,6 +139,7 @@
**function/method calls:**
+ lang=php
// One line
eject($cargo);
@@ -143,6 +150,7 @@
**function/method definitions:**
+ lang=php
function example_function($base_value, $additional_value) {
return $base_value + $additional_value;
}
@@ -157,6 +165,7 @@
**class:**
+ lang=php
class Dog extends Animal {
const CIRCLES_REQUIRED_TO_LIE_DOWN = 3;

File Metadata

Mime Type
text/plain
Expires
Mon, Nov 11, 7:45 PM (2 d, 1 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6712011
Default Alt Text
D13277.diff (1 KB)

Event Timeline

Phabricator · Built by Phacility